Closed Bug 1570097 Opened 4 years ago Closed 4 years ago

Fix shutdown hang in debug docshell tests

Categories

(Core :: DOM: Navigation, defect, P2)

Product:
Core
Component:
DOM: Navigation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Project Flags:
Fission Milestone M4
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1570097: Part 1 - Skip some additional tests that timeout on debug. r=mccr8
47 bytes, text/x-phabricator-request
Details | Review
Bug 1570097: Part 2 - Add missing try-finally in AsyncTabSwitcher. r=mconley
47 bytes, text/x-phabricator-request
Details | Review
No description provided.

For some reason, these timeouts aren't reported as timeouts on automation. The
tests just fail after sitting for 5 minutes doing nothing. Locally, though,
they are reported as timeouts.

Either way, they make the test group run 15 minutes longer than necessary.

With the current code, if any event handler throws, _processing remains
true, and every subsequent event goes into an infinite loop dispatching 0ms
timeouts to run on the next tick.

Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a633cb9096f4
Part 1 - Skip some additional tests that timeout on debug. r=mccr8
https://hg.mozilla.org/integration/autoland/rev/58598c9707bd
Part 2 - Add missing try-finally in AsyncTabSwitcher. r=mconley
Status: NEW → ASSIGNED
Fission Milestone: --- → M4
Priority: -- → P2

https://hg.mozilla.org/mozilla-central/rev/a633cb9096f4
https://hg.mozilla.org/mozilla-central/rev/58598c9707bd

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.