Allow Actors to set |loadURIDelegate| and |webBrowserChrome| on docShell
Categories
(Core :: DOM: Navigation, task, P1)
Tracking
()
People
(Reporter: agi, Assigned: agi)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [geckoview:m1909])
Attachments
(4 files, 1 obsolete file)
loadURIDelegate and webBrowserChrome are set on the docShell inside frame scripts (here on Desktop and here on GeckoView). We need a way to let docShell discover these delegates when they are implented as an Actor.
kmag suggested we use a named Actor that gets loaded by the docShell whenever it needs to use the property.
|
||
Comment 1•5 years ago
|
||
Note we should probably allow explicitly setting webBrowserChrome, at least for now, and fall back to looking up an actor only if hasn't already been set on the top-level content docshell.
Ideally, I think we want to move to using the same actor everywhere, but for the moment, we still use something slightly different for extension panels, and in-process tabs do some magic to use XULBrowserWindow for their nsIWebBrowserChrome3.
|
||
Comment 2•5 years ago
|
||
Thanks Agi for taking this.
|
||
Comment 3•5 years ago
|
||
firefox69=wontfix because we don't need to uplift this fix to Beta.
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
This allows querying the actor for interfaces implemented in JS.
|
|
Assignee | |
Comment 6•5 years ago
|
||
|
|
Assignee | |
Comment 7•5 years ago
|
||
|
|
||
Comment 8•5 years ago
|
||
Adding this bug to GV's September sprint. Agi says his patches are waiting for review.
|
|
Assignee | |
Comment 9•5 years ago
|
||
When DelegatedQueryInterface is called on a XPCWrappedJS that has an aggregated
native object (e.g. in the case of a JS-implemented class that extends a native
object like JSWindowActor), we end up calling QueryInterface on the native
object, even though we know already that the interface is implemented on the JS
object.
To fix this, we bypass the native object QI call by calling
AggregatedQueryInterface.
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Comment 10•5 years ago
|
||
Pushed by asferro@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/84bd781b0b8c Add default handler for OnLoad{Request,Error}. r=droeh https://hg.mozilla.org/integration/autoland/rev/3626cfe835ee Add do_QueryActor to query JS-implemented interfaces. r=kmag https://hg.mozilla.org/integration/autoland/rev/c6ac454bfe48 Move LoadURIDelegate to Actor. r=kmag,snorp https://hg.mozilla.org/integration/autoland/rev/205690af8630 Allow Actors to implement WebBrowserChrome. r=kmag,snorp
|
||
Comment 11•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/84bd781b0b8c
https://hg.mozilla.org/mozilla-central/rev/3626cfe835ee
https://hg.mozilla.org/mozilla-central/rev/c6ac454bfe48
https://hg.mozilla.org/mozilla-central/rev/205690af8630
|
||
Updated•5 years ago
|
Description
•