1570239 - GenerateMessages in Localization.webidl shouldn't take locales parameter

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Axel Hecht [:Pike]]

In dom/chrome-webidl/Localization.webidl, we have the signature:

callback GenerateMessages = Promise<any> (sequence<DOMString> aAppLocales, sequence<DOMString> aResourceIds);

That matches the signature of the l10n registry, but not the signature that Localization.jsm ends up using, which would be just

Promise<any> (sequence<DOMString> aResourceIds)

This also reflects in the test cases, https://searchfox.org/mozilla-central/search?q=mockGenerateMessages&case=false&regexp=false&path=.

Stas fixed on those in intl, but this also needs fixes in dom/l10n/.

Or did we miss something, Zibi?

Comment 1

[Staś Małolepszy :stas]

(In reply to Axel Hecht [:Pike] from comment #0)

Stas fixed on those in intl, but this also needs fixes in dom/l10n/.

For the record, I filed bug 1568966 about this in intl/l10n/test, and the fix landed as part of bug 1568914.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Or did we miss something, Zibi?

Nope, I don't think so. It's just my mistake. Thanks for investigating!

Taking.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1570239 - GenerateMessages in Localization.webidl shouldn't take locales parameter.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f01f7bfe772a
GenerateMessages in Localization.webidl shouldn't take locales parameter. r=Pike

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/f01f7bfe772a