1570251 - Address bar input field and autocomplete results list don't line up anymore

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P1)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1548198 +++

I believe bug 1569182 regressed this.

Comment 2

[Dão Gottwald [:dao]]

According to bug 1570008 comment 23, it seems that this isn't fully fixed yet.

Comment 3

[Johann Hofmann [:johannh]]

Removing priority so that this shows up in our triage...

Comment 4

[Mehmet]

Attachment: actual.png

From Comment 23 of bug 1570008:

It looks like the Text input needs to be shifted 2px to the left when the proxy state is valid. That would look much more balanced with the other spacings in the Address Bar and be aligned again with the Drop Down text.

Comment 5

[Mehmet]

Attachment: expected.png

Comment 6

[Marco Bonardo [:mak]]

please see also bug 1570663. I suspect there's some relation

Comment 7

[Drew Willcoxon :adw]

Tim, could you please look at this and bug 1570663?

Comment 8

[Tim Huang[:timhuang]]

Sure.

Comment 9

[Tim Huang[:timhuang]]

I am wondering one thing here. If we change to align the awesome bar to the shield icon in Bug bug 1570663, do we still care about to align input text when the awesome bar is shown by the dropdown button? There will be a gap between the text in the awesome bar and the input text anyway in this case and this matches the old behavior, per Bug 1570663 comment 4, when there were an "i" icon and the lock icon on the url bar. So, maybe we don't need to align the text if using the dropdown button?

Comment 10

[Drew Willcoxon :adw]

That's what I needinfo'ed verdi on. I'll ping him again. But probably we should just do what we were doing, align the icons with the shield (which took the place of the "i") and not align the text.

Comment 11

[(inactive) Nihanth Subramanya [:nhnt11]]

Is there still anything left to do here? Sorry to bug you Drew, but I can't tell for sure if other changes have fixed this bug at this point. Could you help? If there's something to be done I am happy to write the patch.

Comment 12

[(inactive) Nihanth Subramanya [:nhnt11]]

see comment 11

Comment 13

[Drew Willcoxon :adw]

Hi Nihanth, no problem. Thanks for following up. This appears to be fixed!

Comment 14

[Drew Willcoxon :adw]

There is bug 1575441 though, sigh...

Comment 15

[Mehmet]

(In reply to Drew Willcoxon :adw from comment #13)

Hi Nihanth, no problem. Thanks for following up. This appears to be fixed!

Please consider Bug 1578093. Thanks :)