1570253 - Make session history sync IPC messages that don't return anything async

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P3)

Description

[Peter Van der Beken [:peterv]]

It should be possible to just convert all sync messages that don't return anything to be async. Here's a list:

PSHistory
  sync InternalSetRequestedIndex(int32_t index);
  sync UpdateIndex();
  sync EvictOutOfRangeContentViewers(int32_t index);
  sync EvictAllContentViewers();
  sync RemoveDynEntries(int32_t index, PSHEntry entry);
  sync RemoveFrameEntries(PSHEntry entry);
  sync Evict(PSHEntry[] entry);
  sync EnsureCorrectEntryAtCurrIndex(PSHEntry entry);
  sync EvictContentViewersOrReplaceEntry(nullable PSHEntry newSHEntry, bool replace);

PSHEntry
  sync SetURI(nsIURI uri);
  sync SetOriginalURI(nsIURI originalUri);
  sync SetResultPrincipalURI(nsIURI resultPrincipalUri);
  sync SetLoadReplace(bool loadReplace);
  sync SetTitle(nsString title);
  sync SetIsSubFrame(bool isSubFrame);
  sync SetReferrerInfo(nsIReferrerInfo referrerInfo);
  sync SetSticky(bool sticky);
  sync SetPostData(nsIInputStream postData);
  sync SetParent(nullable PSHEntry parentEntry);
  sync SetLoadType(uint32_t loadType);
  sync SetID(uint32_t id);
  sync SetCacheKey(uint32_t cacheKey);
  sync SetExpirationStatus(bool expirationStatus);
  sync SetContentType(nsCString contentType);
  sync SetURIWasModified(bool uriWasModified);
  sync SetTriggeringPrincipal(nsIPrincipal triggeringPrincipal);
  sync SetPrincipalToInherit(nsIPrincipal principalToInherit);
  sync GetStoragePrincipalToInherit()
  sync SetStoragePrincipalToInherit(nsIPrincipal storagePrincipalToInherit);
  sync SetCsp(nsIContentSecurityPolicy csp);
  sync SetStateData(ClonedMessageData stateData);
  sync SetDocshellID(nsID docshellId);
  sync SetSrcdocData(nsString srcdocData);
  sync SetBaseURI(nsIURI baseUri); 
  sync SetScrollRestorationIsManual(bool scrollRestorationIsManual);
  sync SetLastTouched(uint32_t lastTouched);
  sync SetPersist(bool persist);
  sync SetScrollPosition(int32_t x, int32_t y);
  sync SetViewerBounds(nsIntRect bounds);
  sync Create(nsIURI URI, nsString title, nsIInputStream inputStream,
              uint32_t cacheKey, nsCString contentType,
              nsIPrincipal triggeringPrincipal, nsIPrincipal principalToInherit,
              nsIPrincipal storagePrincipalToInherit,
              nsIContentSecurityPolicy csp, nsID docshellID,
              bool dynamicCreation, nsIURI originalUri, nsIURI resultPrincipalURI,
              bool loadReplace, nsIReferrerInfo referrerInfo,
              nsString srcdoc, bool srcdocEntry, nsIURI baseURI,
              bool saveLayoutState, bool expired);
  sync AbandonBFCacheEntry(uint64_t aNewSharedID);
  sync SetLoadTypeAsHistory();
  sync ClearEntry(uint64_t aNewSharedID);

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Bug 1570253 - Convert session history sync IPC messages that don't return anything to async. r?nika!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:peterv, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Neha Kochar [:neha]]

Landed in ash - https://hg.mozilla.org/projects/ash/rev/3da2f0f2d95bf2452caf7afc06a5c4887e477068

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/81637d1074d5
Convert session history sync IPC messages that don't return anything to async. r=nika

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/81637d1074d5