1570279 - Bug 1508287 disabled some checks in test_objectgrips-17.js

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Oriol Brufau [:Oriol]]

Bug 1508287 refactored test_objectgrips-17.js

When I wrote the test, I used null to refer to a NullPrincipal. But after the refactoring, debuggeePrincipal is a NullPrincipal object.

Therefore, this conditional never runs:

  if (debuggeePrincipal === null) {
    // Test objects created in a same-origin null principal new global.
    await testPrincipal(
      options,
      Cu.getObjectPrincipal(debuggee),
      debuggeeHasXrays
    );
  }

Also, just fixing the condition is not enough, because threadFrontTest ignores the wantXrays parameter.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1570279 - Reenable accidentally disabled checks in test_objectgrips-17.js. r?ochameau

Comment 2

[Oriol Brufau [:Oriol]]

Attachment: Bug 1570279 - Some refactoring for test_objectgrips-17.js. r?ochameau

Depends on D40022

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/09384c51f127
Reenable accidentally disabled checks in test_objectgrips-17.js. r=ochameau
https://hg.mozilla.org/integration/mozilla-inbound/rev/7acf0e8d6a66
Some refactoring for test_objectgrips-17.js. r=ochameau

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/09384c51f127
https://hg.mozilla.org/mozilla-central/rev/7acf0e8d6a66

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/445433a1de44
https://hg.mozilla.org/releases/mozilla-beta/rev/784bd1c95abe

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/d5c0e2bba0f8
https://hg.mozilla.org/releases/mozilla-esr68/rev/769165a6b124