1570289 - openOptionsDialog doesn't scroll to the right element when Preferences tab is already opened

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Onno Ekker [:nONoNonO UTC+1]]

In bug 1498332 the panes are converted to categories/groupboxes on one page. The function openOptionsDialog however still tries to select a pane, instead of scrolling to the specified element. E.g. when you select Message > Tags > Manage Tags, the preferences tab should switch to the General pane and scroll down to Tags, but this last step doesn't work.

Comment 1

[Richard Marti (:Paenglab)]

The Manage Tags example works for me. Also the other places where it has to scroll to a special area works for me. You tried without extensions?

Comment 2

[Onno Ekker [:nONoNonO UTC+1]]

Yes, I just tried with latest Daily in safe-mode. It seems to work when the Preferences tab is closed before you select the function, but when the tab is already opened, the view doesn't scroll to the right place.

Comment 3

[Richard Marti (:Paenglab)]

Geoff, do you know why it doesn't scroll when the prefs are already open? Switching the pane still works.

Comment 4

[Geoff Lankow (:darktrojan)]

It looks like in preferencesTab.js, we've still got tabID instead of scrollPaneTo, in several places.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1570289-rename-tabID-to-scrollPaneTo.patch

Yes, with renaming it works. Thanks for the tip.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9082545 [details] [diff] [review]
1570289-rename-tabID-to-scrollPaneTo.patch

rs=jorgk, I need a patch and this looks about right.

Comment 7

[Jorg K (CEST = GMT+2)]

Oh, found another bug to land ;-)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bfe2c75b1668
Rename remaining "tabID" to "scrollPaneTo" in preferencesTab.js. r=darktrojan DONTBUILD