Closed Bug 1570289 Opened 2 years ago Closed 2 years ago

openOptionsDialog doesn't scroll to the right element when Preferences tab is already opened

Categories

(Thunderbird :: Preferences, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 70.0

People

(Reporter: nONoNonO, Assigned: Paenglab)

References

Details

Attachments

(1 file)

In bug 1498332 the panes are converted to categories/groupboxes on one page. The function openOptionsDialog however still tries to select a pane, instead of scrolling to the specified element. E.g. when you select Message > Tags > Manage Tags, the preferences tab should switch to the General pane and scroll down to Tags, but this last step doesn't work.

The Manage Tags example works for me. Also the other places where it has to scroll to a special area works for me. You tried without extensions?

Yes, I just tried with latest Daily in safe-mode. It seems to work when the Preferences tab is closed before you select the function, but when the tab is already opened, the view doesn't scroll to the right place.

Summary: openOptionsDialog doesn't scroll to the right element → openOptionsDialog doesn't scroll to the right element when Preferences tab is already opened

Geoff, do you know why it doesn't scroll when the prefs are already open? Switching the pane still works.

Flags: needinfo?(geoff)

It looks like in preferencesTab.js, we've still got tabID instead of scrollPaneTo, in several places.

Flags: needinfo?(geoff)

Yes, with renaming it works. Thanks for the tip.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9082545 - Flags: review?(geoff)
Comment on attachment 9082545 [details] [diff] [review]
1570289-rename-tabID-to-scrollPaneTo.patch

rs=jorgk, I need a patch and this looks about right.
Attachment #9082545 - Flags: review+

Oh, found another bug to land ;-)

Attachment #9082545 - Flags: review?(geoff) → review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/bfe2c75b1668
Rename remaining "tabID" to "scrollPaneTo" in preferencesTab.js. r=darktrojan DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 70.0
You need to log in before you can comment on or make changes to this bug.