Make the link to about:settings#privacy accessible
Categories
(Firefox :: Protections UI, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: MarcoZ, Assigned: mtigley)
References
Details
(Keywords: access, Whiteboard: [protection-report] [skyline])
Attachments
(1 file)
Quoting :fvsch from bug 1561334 comment #1:
Currently coded as a paragraph with a click event handler.
We should probably use a link, going from:
<p id="protection-details" onClick="...">
Protection Level is set to <span>Standard</span>
</p>
to:
<p id="protection-details">
<a href="about:settings#privacy" target="_blank" title="Go to privacy settings">
Protection Level is set to <strong>Standard</strong>
</a>
</p>
or maybe:
<p id="protection-details">
<a href="about:settings#privacy" target="_blank">
Protection Level is set to <strong>Standard</strong>
<span class="visually-hidden">(Go to privacy settings)</span>
</a>
</p>
I think it's important to have extra information that explains what the link does. A title attribute might be useful for all users so I would go with that, if we think it will be rendered correctly as additional information in screen readers when the link is focused. We might want to combine both solutions too. This would need some testing in e.g. Windows + NVDA.
And Jamie suggested in bug 1561334 comment #3:
Given the technical challenge, I think we can get the same effect for a11y semantics using ARIA:
<p id="protection-details" role="link" tabindex="0" onClick="..." title="Go to Privacy settings">
Protection Level is set to <span>Standard</span>
</p>
(I agree the user, whether or not they use assistive technology, should have some idea of what this link does and the title attribute seems like a good approach.)
I agree with Jamie, we should go with this approach.
Comment 1•5 years ago
|
||
Bugbug thinks this bug is a enhancement, but please change it back in case of error.
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a529b0832b90 Ensure that links to about:* pages are accessible. r=ewright,fluent-reviewers,flod
Comment 4•5 years ago
|
||
bugherder |
Description
•