1570302 - Conflicting mime kwarg in inline() helper function

Status: RESOLVED FIXED

(Testing :: geckodriver, defect, P1)

Description

[Andreas Tolfsen ❲:ato❳]

The inline() helper function used in WPT wdspec tests take a
mime keyword argument, but it is effectively overridden by the
default media type for the different document types.

It should either be fixed so that you can use an alternate MIME
type for the selected document type, or it should be removed entirely.

I scanned the code base and could not find any callers that needed
to override the recommended media type, so I’m leading towards
removing the keyword argument.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1570302: webdriver: refactor document inlining helper;

The inline() function has a bug where the mime keyword argument is
ignored: if the doctype is recognised, the media type is overridden
with the default for that document type.

This patch's primary motivation is to fix that bug, so that the
media type may be configured individually from the document type.

The result of this ended in a larger refactoring of the inlining
helper so that the character set may also be individually configured.
The result of the combined changes is hopefully that the code is
easier to understand, along with its new documentation.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1570302: webdriver: make collection tests count <meta>;

The HTML boilerplate now includes a <meta charset=utf-8> element,
and the Execute (Async) Script collection tests must include this
in its checks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e595a5b01413
webdriver: refactor document inlining helper; r=#webdriver
https://hg.mozilla.org/integration/mozilla-inbound/rev/21696af2ddec
webdriver: make collection tests count <meta>; r=whimboo

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18292 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/18292
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/eR_xVf9fTMua7lj2A0bYow)

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e595a5b01413
https://hg.mozilla.org/mozilla-central/rev/21696af2ddec

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged