Expand the testing of GeckoView Streaming
Categories
(Toolkit :: Telemetry, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: chutten, Assigned: chutten)
References
Details
Attachments
(2 files)
In bug 1566366 I introduced some barebones testing of the obvious functionality.
We should expand the testing to include, at a minimum, whatever the "final batch mechanism" is from bug 1570305. As well as multiple histograms, multiple samples, and (if gtest will let us) multiple threads.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
With the new StaticPrefsList (and possibly earlier?) prefs accessed on non-main
threads must now be atomic or assert-fail.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Adds:
- Multiple Histogram test (nothing too interesting here)
- Multiple Thread test (...)
The multithread test was a tricky one to get right, and even still I'm not
100% convinced that it's testing contention properly enough to expose any
thread-unsafety inside the batching accumulator.
That said, it does exercise the API on non-main threads, so I'm still calling
it a win.
Depends on D43447
Pushed by chutten@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/58e6e108dc33 Allow telemetry.batchDurationMS pref to be accessed on multiple threads. r=janerik https://hg.mozilla.org/integration/autoland/rev/64609c0ca292 More GV Streaming Telemetry Tests r=janerik
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/58e6e108dc33
https://hg.mozilla.org/mozilla-central/rev/64609c0ca292
Description
•