Closed Bug 1570307 Opened 1 year ago Closed 5 months ago

Expand the testing of GeckoView Streaming

Categories

(Toolkit :: Telemetry, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: chutten, Assigned: chutten)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

In bug 1566366 I introduced some barebones testing of the obvious functionality.

We should expand the testing to include, at a minimum, whatever the "final batch mechanism" is from bug 1570305. As well as multiple histograms, multiple samples, and (if gtest will let us) multiple threads.

Assignee: nobody → chutten
Status: NEW → ASSIGNED
Priority: -- → P2

With the new StaticPrefsList (and possibly earlier?) prefs accessed on non-main
threads must now be atomic or assert-fail.

Adds:

  • Multiple Histogram test (nothing too interesting here)
  • Multiple Thread test (...)

The multithread test was a tricky one to get right, and even still I'm not
100% convinced that it's testing contention properly enough to expose any
thread-unsafety inside the batching accumulator.

That said, it does exercise the API on non-main threads, so I'm still calling
it a win.

Depends on D43447

Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58e6e108dc33
Allow telemetry.batchDurationMS pref to be accessed on multiple threads. r=janerik
https://hg.mozilla.org/integration/autoland/rev/64609c0ca292
More GV Streaming Telemetry Tests r=janerik
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.