1570327 - Hide robot icon when the address bar is in edit mode

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Andreas Tolfsen ❲:ato❳]

This is a follow-up to bug 1570292 to hide the robot icon, which
is present when the browser session is being remotely controlled.

mak’s comment over in D40037 says:

As I said on IRC, in a followup you may evaluate
to hide this icon when the urlbar pageproxystate
is not valid, for consistency, unless there is a
strong reason to always have this icon visible.
See https://searchfox.org/mozilla-central/rev/38c88cbf4be87dfa0636d15a5d3599a8ea0d1a72/browser/themes/shared/identity-block/identity-block.inc.css#27

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1570327: browser: hide robot icon from address bar in edit mode;

When the address bar is in edit mode, e.g. the user is typing and
the address bar text field has focus, we hide some of the icons in
the identity box.

For the sake of consistency, we should also do this for the robot
icon that is present when the browser session is under remote control.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ffc0676a647
browser: hide robot icon from address bar in edit mode; r=mak

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1ffc0676a647