157033 - Spawning tabs causes progress bar to no longer display on Status Bar

Status: VERIFIED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Benoit]

The progress indicator doesn't work anymore when you open more than one tab in
the  window. It never shows up again, closing all the tabs doesn't solve the
problem.

This is because we don't keep track of the NSProgressIndicator superview
correctly when switching from tabs.

I'm attaching a patch that moves the responsability of hiding/showing the
progress indicator in the BroswerWindowController. The superview is cached when
the window is loaded. Hope you'll like the patch!

Comment 1

[Benoit]

Attachment: fix progress indicator disapearance problem

Comment 2

[Greg K.]

Confirmed using Chimera/20020708.

Comment 3

[Greg K.]

*** Bug 158237 has been marked as a duplicate of this bug. ***

Comment 4

[Benoit]

Attachment: updated patch

updated patch to reflect the current status of the repository as of 08/04.

Comment 5

[saari (gone)]

->pinkerton

Comment 6

[Simon Fraser [no longer active]]

Is this still a problem?

Comment 7

[Mike Pinkerton (not reading bugmail)]

landed. thanks for the patch!

Comment 8

[sairuh (rarely reading bugmail)]

hrm, i'm not sure if this is really fixed. using the 2002.08.27.05 build, i can
sometimes see the progress meter on the multiple tabs, but sometimes i cannot.

here's how i tested this (two cases):

case a
------
1. had three tabs open: one with a bug listing, and two with a bug report loaded.
2. on any of the tabs, i hit the reload button.

results: sometimes the progress meter appears in the status bar and paints as
expected. sometimes, however, it doesn't appear at all even though the status
text says "Loading..."

case b
------
1. had three tabs open: one with a bug listing, and two with a bug report loaded.
2. in the first tab with the bug listing, cmd-click a bug link to load it in
another tab (i have the pref to open in background, fwiw).
3. quickly go to this new (4th) tab and watch the status bar.

results: other than encountering bug 164706 ("untitled" appearing while page is
loading), eventually i do see "Transferring..." text, but no progress meter ever
appears.

benoit, does this fix help the particular issue you mentioned?

are cases (a) and (b) different issues from this bug?

Comment 9

[Benoit]

I can't reproduce a), if I have several tabs open and hit the reload button in
one tab the progress bar always shows up.

b) is easy to fix, Mike in src/browser/BrowserWrapper.mm Line 50 add:

  else
    [mWindowController showProgressIndicator];

Sorry, I missed that!

Comment 10

[Simon Fraser [no longer active]]

Line 50? That doesn't make sense. Can you paste a patch please?

Comment 11

[sairuh (rarely reading bugmail)]

reopening based on comment 9.

Comment 12

[Benoit]

Attachment: additional patch

Indeed, no idea how I came up with this line 50! It should probably be 176
instead. Attached the patch.

Comment 13

[Simon Fraser [no longer active]]

Taking

Comment 14

[Simon Fraser [no longer active]]

The patch didn't do enough. Each browser wrapper has to main its own progress
level, and set the progress meter to the correct state and value when it becomes
primary. I fixed all that.

Comment 15

[sairuh (rarely reading bugmail)]

ahhh, much better. :)

vrfy'd fixed on 10.2.2 with 2002.12.03.04.