1570332 - New bookmark popup shows Firefox Sync ad, but "Feature Recommendations" are turned off

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Christoph Kisfeld]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

• I turned off "Recommend extensions as you browse" and "Recommend features as you browse" in settings a long time ago.
• Opened a new private window,
• went to a website
• and clicked the bookmark (star) button in the address bar.

I am not able to reproduce this currently, I am not sure how these ads/recommendations are triggered.

Actual results:

The "New Bookmark" popup showed an ad for Firefox Sync, in place of / overlaying the screenshot of the current website.

Expected results:

A recommendation for Firefox Sync should not have appeared due to the setting "Recommend features as you browse" being turned off.

Comment 1

[Ryan Kelly [:rfkelly]]

Thanks for the report.

I'm not sure of the right bugzilla component for...maybe "Messaging System"?

Comment 2

[Christoph Kisfeld]

Thanks Ryan

The logic for displaying recommendations seems to be located here

https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser-places.js#257
https://dxr.mozilla.org/mozilla-central/source/browser/components/newtab/lib/BookmarkPanelHub.jsm#70

I think "Bookmarks & History" is the more correct component? According to the bugzilla components list for Firefox: "This includes the [...] add and modify bookmarks dialogs"

I can't make the recommendation show up on a new Firefox 68.0.1 installation with new profile (with Feature Recommendations default on, non-private window), again not sure what the trigger is aside from "open bookmarks add/edit panel"..

Comment 3

[Marius Coman [:mcoman], Ecosystem QA]

I have managed to reproduce this issue using latest Firefox Release (68.0.1), latest Firefox Beta (69.0b9) and latest Firefox Nightly (70.0a1) on Windows 10 x64, Mac 10.14.6 and Arch Linux, using the following steps:

[Prerequisites]:

• Have at least 10 bookmarks.
• Have the "Recommend extensions as you browse" and "Recommend features as you browse" options disabled from the "about:preferences" page.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to any website and click the "Bookmark this page" button from the right part of the "Address Bar".
3. Observe the behavior.

[Expected result]:

• The "Bookmark" panel is opened.

[Actual result]:

• The "Sync to CTA when Bookmarking" message is also displayed inside the "Bookmark" panel.

[Notes]:

• The message will be displayed just once in a day and for a maximum of 3 times.
• We have also verified that the CFR Add-ons and CFR Pin Tab features are not affected by this issue.

Comment 4

[Andrei Oprea [:andreio]]

Confirmed with :Aaron we'll want to fix this.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5260

Comment 7

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/f70ae5522218

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Can this ride Fx71 to release?

Comment 9

[Andrei Oprea [:andreio]]

Attachment: Bug 1570332 - New bookmark popup shows Firefox Sync ad, but 'Feature Recommendations' are turned off

Comment 10

[Andrei Oprea [:andreio]]

Comment on attachment 9099632 [details]
Bug 1570332 - New bookmark popup shows Firefox Sync ad, but 'Feature Recommendations' are turned off

Beta/Release Uplift Approval Request

• User impact if declined: CFR message shown even if user opted out
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small patch. Already landed in nightly.
• String changes made/needed:

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9099632 [details]
Bug 1570332 - New bookmark popup shows Firefox Sync ad, but 'Feature Recommendations' are turned off

Important to comply with user preferences, let's uplift for beta 14.

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c878bf8a73bb

Comment 13

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (71.0a1 Build ID - 20191010214019) installed. Now, the "Sync to CTA when Bookmarking" message is not displayed inside the "Bookmark" panel if the "Recommend extensions as you browse" and "Recommend features as you browse" options are disabled from the "about:preferences" page.

However this issue is still reproducible on the latest Firefox Beta (70.0b14 Build ID - 20191010142853), the "Sync to CTA when Bookmarking" message is displayed even if the "Recommend extensions as you browse" and "Recommend features as you browse" options are disabled from the "about:preferences" page. Considering this I am reopening this issue.

Tested on Windows 10 x64, Arch Linux and Mac 10.14.5

Comment 14

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (70.0b14 Build ID - 20191010142853) installed on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the "Sync to CTA when Bookmarking" message is not displayed inside the "Bookmark" panel if the "Recommend extensions as you browse" and "Recommend features as you browse" options are disabled from the "about:preferences" page.