Closed Bug 1570343 Opened 3 years ago Closed 3 years ago

Cranelift: pass the gc/disabled.js test

Categories

(Core :: JavaScript: WebAssembly, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

References

Details

Attachments

(1 file)

Bonus refactoring for the ModuleEnvironment ctor. Luke, I'd send this review to Lars if he weren't on PTO, and I think you know this code well too.

It cringes me a bit that when reftypes are enabled in Cranelift, we have three places to update:

  • HasRefTypesSupport
  • computeParameters
  • other places in this patch where we check if the compiler is Cranelift or not.

Which is the same problem of compiler gating as exposed in bug 1566427.

Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/73ae74f44aa6
Guard the use of wasm ref types opcodes with dynamic checks; r=luke
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.