about:protections off-by-one compared to about:logins
Categories
(Firefox :: Protections UI, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | verified |
People
(Reporter: kristian, Assigned: mtigley)
Details
(Whiteboard: [protection-report][skyline])
Attachments
(1 file)
about:logins shows all logins expect the "Firefox Accounts credentials". "Passwords stored securely" on about:protections count all logins including "Firefox Accounts credentials".
I find that confusing, they should show the same number of logins. At the moment about:protections show +1 more than login than about:logins.
|
Reporter | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
We can fix this by getting the count for Firefox Credentials Services.logins.countLogins("chrome://FirefoxAccounts", null, "Firefox Accounts credentials") and use this to subtract from the total login count that's already reported. Thanks :MattN for the suggestion!
|
|
Reporter | |
Comment 2•5 years ago
|
||
(In reply to Micah Tigley [:mtigley] from comment #1)
We can fix this by getting the count for Firefox Credentials
Services.logins.countLogins("chrome://FirefoxAccounts", null, "Firefox Accounts credentials")and use this to subtract from the total login count that's already reported. Thanks :MattN for the suggestion!
I'm not very familiar with the Firefox codebase, but couldn't we just use "LoginHelper.getAllUserFacingLogins().length"?
|
|
Assignee | |
Comment 3•5 years ago
|
||
(In reply to Kristian Klausen from comment #2)
(In reply to Micah Tigley [:mtigley] from comment #1)
We can fix this by getting the count for Firefox Credentials
Services.logins.countLogins("chrome://FirefoxAccounts", null, "Firefox Accounts credentials")and use this to subtract from the total login count that's already reported. Thanks :MattN for the suggestion!I'm not very familiar with the Firefox codebase, but couldn't we just use "LoginHelper.getAllUserFacingLogins().length"?
This would trigger a master password prompt (if one is set), which we would like to avoid.
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a815c40e818 Show only user facing logins in Lockwise card. r=ewright
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
|
||
Updated•5 years ago
|
|
||
Comment 7•5 years ago
|
||
I’ve reproduced this issue with Fx 70.0a1 (2019-08-01) on Windows 10 x64.
The issue is verified fixed with Fx 71.0a1 (2019-10-16) and Fx 70.0 across platforms (Windows 10 x64, macOS 10.14, Ubuntu 18.04 x64).
Description
•