1570378 - Add shorthand for setting up tests without URL

Status: RESOLVED FIXED

(Remote Protocol :: Agent, enhancement, P1)

Description

[Andreas Tolfsen ❲:ato❳]

For browser-chrome tests we have setupTestForUri which takes a URL
and does the necessary setup to ensure tests are executed in fresh tabs.

Often this is called with an empty document:

setupTestForUri("data:text/html,")

We can avoid some boilerplate if we have a setup helper
that by default chooses an empty document.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1570378: remote: avoid URI terminology

Per the URL standard, we should avoid talking about URIs (and indeed
URI, URN, et al.) since the term only serves to mislead.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1570378: remote: add bc test helper setup() for empty documents

For many browser-chrome (bc) tests is does not matter what the
document is, as long as it is does not cause state to bleed over
from the previous test.

For these cases this patch introduces a shorthand, setup(), which
calls setupForURL(url) with an empty document generated by toDataURL("").

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adb3dec1090b
remote: avoid URI terminology r=remote-protocol-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/412894c27fa2
remote: add bc test helper setup() for empty documents r=remote-protocol-reviewers,jdescottes

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backout for ESlint failure on browser_page_javascriptDialog_

Backout link: https://hg.mozilla.org/integration/autoland/rev/4f81a4f40f888b0881e4fb07505768a815463e42
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=259897330&repo=autoland&lineNumber=287

Comment 5

[Andreas Tolfsen ❲:ato❳]

eslint errors are to do with changes from bug 1545724.
Will rebase and fix these.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfb2d2aae87e
remote: avoid URI terminology r=remote-protocol-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/ff3de1766033
remote: add bc test helper setup() for empty documents r=remote-protocol-reviewers,jdescottes

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/dfb2d2aae87e
https://hg.mozilla.org/mozilla-central/rev/ff3de1766033