1570392 - gfx/layers/CompositionRecorder.cpp and gfx/layers/wr/WebRenderCompositionRecorder.cpp are untested

Status: NEW

(Core :: Graphics, defect, P3)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:ekyle, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Sotaro Ikeda [:sotaro]]

CompositionRecorder.cpp and WebRenderCompositionRecorder.cpp are worked by :barret recently.

:barret, can you take a bug?

Comment 3

[Beth Rennie [:beth] (she/her)]

I can that this but it is low on my priority list for the rest of the quarter.

Comment 4

[singuliere]

Attachment: Bug 1570392 - CompositionRecorder test coverage

Improve the test coverage for gfx/layers/CompositionRecorder.cpp

Comment 5

[singuliere]

I'd like to work on this, if that's ok with you. Is https://phabricator.services.mozilla.com/D43475 going in the direction you want?

Comment 6

[Beth Rennie [:beth] (she/her)]

I think this approach is fine for the plain CompositionRecorder, but it doesn't test the WebRenderCompositionRecorder. However, that requires WebRender to be running which I don't know that we can do in gtests.

:mstange, is this is a sufficient test for non-webrender CompositionRecorder? Can we even test the WebRenderCompositionRecorder from gtests?

:singuliere, ideally I'd also like a mochitest that tests the entire pipeline:

1. Sets the layers.windowrecording.path pref to a new temp directory
2. Starts the composition recorder (via windowUtils.setCompositionRecording(true))
3. Navigates to a new page (e.g. from about:blank to a page with content)
4. Stops the composition recorder (via windowUtils.setCompositionRecording(false))
5. Checks that the temp directory contains a windowrecording-* directory with at least one image.

There may need to be a delay between 4 and 5 to wait for the frames to be written to disk.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Comment 8

[Markus Stange [:mstange]]

Can we even test the WebRenderCompositionRecorder from gtests?

I don't think we can.