Closed Bug 1570453 Opened 2 years ago Closed 2 years ago

Port |Bug 913855 - Fix consumers of window mediator to be more consistent in their checking for closed windows| to SeaMonkey

Categories

(SeaMonkey :: General, task)

task
Not set
normal

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed, seamonkey2.63 wontfix)

RESOLVED FIXED
seamonkey2.67
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed
seamonkey2.63 --- wontfix

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Details

(Whiteboard: SM2.53.1)

Attachments

(2 files, 4 obsolete files)

Back in Gecko 26 this was done for Firefox, so should port:

  • Bug 913855 - Fix consumers of window mediator to be more consistent in their checking for closed windows
Attached patch Patch for c-c (obsolete) — Splinter Review
Attachment #9082078 - Flags: review?(frgrahl)
Attached patch Patch for c-c v1.1 (obsolete) — Splinter Review
Attachment #9082078 - Attachment is obsolete: true
Attachment #9082078 - Flags: review?(frgrahl)
Attachment #9082080 - Flags: review?(frgrahl)
Attached patch Patch for 2.53 (obsolete) — Splinter Review

Equivalent patch for 2.53

For both patches changes to tasksOverlay.js might need more work/dropping.

Attachment #9082088 - Flags: review?(frgrahl)
Attachment #9082088 - Flags: approval-comm-release?
Comment on attachment 9082080 [details] [diff] [review]
Patch for c-c v1.1

Looks good
Attachment #9082080 - Flags: review?(frgrahl) → review+
Comment on attachment 9082088 [details] [diff] [review]
Patch for 2.53

This too
Attachment #9082088 - Flags: review?(frgrahl)
Attachment #9082088 - Flags: review+
Attachment #9082088 - Flags: approval-comm-release?
Attachment #9082088 - Flags: approval-comm-release+
Attachment #9082088 - Flags: approval-comm-esr60+
Attached patch Patch for c-c v1.2 (obsolete) — Splinter Review

Updated changes for tasksOverlays.js

Attachment #9082080 - Attachment is obsolete: true
Attachment #9082902 - Flags: review?(frgrahl)

Updated changes for tasksOverlays.js for 2.53

Attachment #9082088 - Attachment is obsolete: true
Attachment #9082903 - Flags: review?(frgrahl)
Attachment #9082903 - Flags: approval-comm-release?
Attachment #9082903 - Flags: approval-comm-esr60?
Attachment #9082902 - Attachment is obsolete: true
Attachment #9082902 - Flags: review?(frgrahl)
Attachment #9083706 - Flags: review?(frgrahl)
Comment on attachment 9082903 [details] [diff] [review]
Patch for 2.53 v1.2

[Triage Comment]
r/a=me
Attachment #9082903 - Flags: review?(frgrahl)
Attachment #9082903 - Flags: review+
Attachment #9082903 - Flags: approval-comm-release?
Attachment #9082903 - Flags: approval-comm-release+
Attachment #9082903 - Flags: approval-comm-esr60?
Attachment #9082903 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/03b278efa430
Port Bug 913855 "Fix consumers of window mediator to be more consistent in their checking for closed windows" to SeaMonkey". r=frg

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Comment on attachment 9083706 [details] [diff] [review]
Unbitrotted Patch v1.2 for cc

late r+
Attachment #9083706 - Flags: review?(frgrahl) → review+

None of the changes here affect TB, right? The editor/ part is for the SM HTML editor, yes?

None of the changes here affect TB, right? The editor/ part is for the SM HTML editor, yes?
No this is all composer.

Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.