Closed Bug 1570461 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 18219 - Remove the compositionDisabled XRWebGLLayer creation flag

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18219 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18219
Details from upstream follow.

Brandon Jones <bajones@chromium.org> wrote:

Remove the compositionDisabled XRWebGLLayer creation flag

The WebXR spec now states that this value is implied based on the mode of the
session the layer was created with.

Bug: 987352
Change-Id: I5f5999822a3504fbc79934ded29310074c454680
Reviewed-on: https://chromium-review.googlesource.com/1729799
WPT-Export-Revision: 067c1b9737ba984ee8e535860fa8255b289d1d81

PR 18219 applied with additional changes from upstream: 453453af2e854b13228cab2da314cc2a4d1ffc86, 7f168d2902db1dd889b314f597f38148ffcdc963, 81cf7224803a34a2fa3872a9db4ff0f7a3041282, cd3b99a919f2d8119d94c21de51dbbda315f408f, 9cefb45585f175f4bf663e1069f0fb14b5237ef5, 246bb9bff1566be1e082066b58806bdf6a34eee3, 446fbc1f462dce21ac22e4f6e8e2ca3ebb60c31a
Ran 56 tests and 88[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] subtests OK : 13[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] PASS : 2[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] FAIL : 55[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] ERROR : 43[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] NOTRUN : 31[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] New tests that have failures or other problems: /webxr/exclusive_requestFrame_nolayer.https.html: SKIP[android-em-7.0-x86_64-opt-geckoview], ERROR[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] XRSession requestAnimationFrame must fail if the session has no baseLayer for immersive: FAIL[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] XRSession requestAnimationFrame must fail if the session has no baseLayer for non immersive: NOTRUN[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] /webxr/render_state_vertical_fov_immersive.https.html: SKIP[android-em-7.0-x86_64-opt-geckoview], ERROR[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] inlineVerticalFieldOfView is set appropriately on immersively sessions: FAIL[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] /webxr/render_state_vertical_fov_inline.https.html: SKIP[android-em-7.0-x86_64-opt-geckoview], ERROR[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] inlineVerticalFieldOfView is set appropriately on inline sessions: FAIL[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] /webxr/xrSession_requestAnimationFrame_timestamp.https.html: SKIP[android-em-7.0-x86_64-opt-geckoview], ERROR[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] XRFrame getViewerPose updates on the next frame for immersive: FAIL[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] XRFrame getViewerPose updates on the next frame for non-immersive: NOTRUN[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] /webxr/xrView_match.https.html: SKIP[android-em-7.0-x86_64-opt-geckoview], ERROR[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] XRFrame contains the expected views: FAIL[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] /webxr/xrView_oneframeupdate.https.html: SKIP[android-em-7.0-x86_64-opt-geckoview], ERROR[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] XRView projection matrices update near and far depths on the next frame: FAIL[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] /webxr/xrViewport_valid.https.html: SKIP[android-em-7.0-x86_64-opt-geckoview], ERROR[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] XRViewport attributes are valid: FAIL[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] /webxr/xrWebGLLayer_constructor.https.html: SKIP[android-em-7.0-x86_64-opt-geckoview] Ensure that XRWebGLLayer's constructor throws appropriate errors: FAIL[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] /webxr/xrWebGLLayer_framebuffer_draw.https.html: SKIP[android-em-7.0-x86_64-opt-geckoview], ERROR[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] Ensure a WebGL layer's framebuffer can only be drawn to inside a XR frame: FAIL[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] /webxr/xrWebGLLayer_framebuffer_scale.https.html: SKIP[android-em-7.0-x86_64-opt-geckoview], ERROR[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] Ensure framebuffer scaling works as expected.: FAIL[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] /webxr/xrWebGLLayer_opaque_framebuffer.https.html: SKIP[android-em-7.0-x86_64-opt-geckoview], ERROR[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] Ensure that the framebuffer given by the WebGL layer is opaque for immersive: FAIL[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] Ensure that the framebuffer given by the WebGL layer is opaque for non-immersive: NOTRUN[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows10-64-shippable-opt,windows10-64-shippable-qr-opt,windows7-32-debug,windows7-32-opt,windows7-32-shippable-opt] Tests that are disabled for instability: /webxr/events_input_source_recreation.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/events_input_sources_change.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/events_referenceSpace_reset.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/events_session_select.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/events_session_select_subframe.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/getInputPose_handedness.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/getInputPose_pointer.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/webGLCanvasContext_create_xrcompatible.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/webGLCanvasContext_makecompatible_contextlost.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/webxr_availability.http.sub.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrBoundedReferenceSpace_updates.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrDevice_disconnect_ends.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrDevice_requestSession_immersive.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrDevice_requestSession_immersive_no_gesture.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrDevice_requestSession_immersive_unsupported.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrDevice_requestSession_no_mode.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrDevice_requestSession_non_immersive_no_gesture.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrDevice_requestSession_optionalFeatures.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrDevice_requestSession_requiredFeatures_unknown.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrDevice_supportsSession_immersive.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrDevice_supportsSession_immersive_unsupported.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrDevice_supportsSession_non_immersive.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrFrame_getPose.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrFrame_lifetime.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrInputSource_add_remove.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrInputSource_gamepad_disconnect.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrInputSource_gamepad_input_registered.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrReferenceSpace_originOffset.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrReferenceSpace_originOffsetBounded.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrRigidTransform_constructor.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrRigidTransform_inverse.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrSession_cancelAnimationFrame.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrSession_cancelAnimationFrame_invalidhandle.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrSession_end.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrSession_input_events_end.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrSession_prevent_multiple_exclusive.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrSession_requestAnimationFrame_callback_calls.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrSession_requestAnimationFrame_data_valid.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrSession_requestAnimationFrame_getViewerPose.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrSession_requestReferenceSpace.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrSession_requestReferenceSpace_features.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrSession_viewer_referenceSpace.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrStationaryReferenceSpace_floorlevel_updates.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrView_eyes.https.html: [android-em-7.0-x86_64-opt-geckoview] /webxr/xrWebGLLayer_viewports.https.html: [android-em-7.0-x86_64-opt-geckoview]
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1d77e108e935 [wpt PR 18219] - Remove the compositionDisabled XRWebGLLayer creation flag, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/c20d7fbc7a84 [wpt PR 18219] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/1d77e108e935
https://hg.mozilla.org/mozilla-central/rev/c20d7fbc7a84

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.