1570466 - [Protection Report] Enhanced Tracking Protection card when some/all protections are off in Custom

Status: RESOLVED FIXED

(Firefox :: Protections UI, enhancement, P3)

Description

[Eric Pang [:epang] UX]

The ETP card reflects which protections are on/off.

For example, if Crytomining is unchecked in custom it should not be shown in the ETP card.

When all protections are off the is no graph shown and the CTA changes to managing protection settings.

See the last screen in the spec:
https://mozilla.invisionapp.com/share/W6T7F6RMJ39#/360923276_Protection_Report

Comment 1

[Johann Hofmann [:johannh]]

This seems like enough of an edge case to put it on the backlog, but can you please file a P1 bug for the TP in Standard Mode issue?

Comment 2

[Eric Pang [:epang] UX]

(In reply to Johann Hofmann [:johannh] from comment #1)

This seems like enough of an edge case to put it on the backlog, but can you please file a P1 bug for the TP in Standard Mode issue?
Filed 1571017 for hiding 'Tracking Content' on the ETP graph in Standard Mode.

Comment 3

[Johann Hofmann [:johannh]]

Awesome, thank you!

Comment 4

[Erica Wright [:ewright]]

Attachment: Bug 1570466 - Enhanced Tracking Protection card hides content when some/all protections are off in Custom

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84d18816918c
Enhanced Tracking Protection card hides content when some/all protections are off in Custom r=fluent-reviewers,johannh,flod

Comment 6

[Oana Pop-Rus]

Backed out changeset 84d18816918c (bug 1570466) for bc perma failures in browser_protections_report_ui.js

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=84d18816918c18b14d05591481d1351765448144&selectedJob=273407888

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=273407888&repo=autoland&lineNumber=29453

Backout: https://hg.mozilla.org/integration/autoland/rev/9b2ebbf56577ec44c8c2304564bd003e1ccf0231

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9779a963015f
Enhanced Tracking Protection card hides content when some/all protections are off in Custom r=fluent-reviewers,johannh,flod

Comment 8

[Andreea Pavel [:apavel]]

Backed out for failing browser_parsable_css.js

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&searchStr=os%2Cx%2C10.14%2Cshippable%2Copt%2Cmochitests%2Ctest-macosx1014-64-shippable%2Fopt-mochitest-browser-chrome-e10s-5%2Cm%28bc5%29&revision=9779a963015fa5f34ce2752d8f8179977c80bbd9&selectedJob=273831870

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=273828364&repo=autoland&lineNumber=2068

Backout: https://hg.mozilla.org/integration/autoland/rev/a62726990552345f6581cf9e5acc7fe95bbf678d

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a5de28bca60
Enhanced Tracking Protection card hides content when some/all protections are off in Custom r=fluent-reviewers,johannh,flod

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5a5de28bca60