1570475 - Remove caching of login object on the login-list-items

Status: RESOLVED FIXED

(Firefox :: about:logins, task, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

With bug 1566115 we now have a map of guid -> {login, listItem} and as such we don't need to cache the login object on the listItem.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1570475 - Fix reference to the first list item. r?MattN

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1570475 - Remove caching of login object on login-list-items. r?MattN

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1570475 - Reduce code duplication when selecting the first login, also make sure that the login being selected is visible in the list. r?MattN

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1570475 - Show file:// as the title on the login-list-item for saved file:// logins. r?MattN

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1570475 - Saving a login should select the login. r?MattN

The AboutLoginsCreateLogin event was being used in two different contexts, one to signal to AboutLoginsChild.jsm that a new login was created and in a second context to signal within the page that the user wanted to start creating a new login. This overloading of the event has now been fixed. There was also another issue when comparing the typed origin to the saved origin which has been fixed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f994225862f8
Fix reference to the first list item. r=MattN
https://hg.mozilla.org/integration/autoland/rev/703345834e49
Remove caching of login object on login-list-items. r=MattN
https://hg.mozilla.org/integration/autoland/rev/1ba5e4238db6
Reduce code duplication when selecting the first login, also make sure that the login being selected is visible in the list. r=MattN
https://hg.mozilla.org/integration/autoland/rev/acfdfbb04139
Show file:// as the title on the login-list-item for saved file:// logins. r=MattN
https://hg.mozilla.org/integration/autoland/rev/c9517c3c6223
Saving a login should select the login. r=MattN

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f994225862f8
https://hg.mozilla.org/mozilla-central/rev/703345834e49
https://hg.mozilla.org/mozilla-central/rev/1ba5e4238db6
https://hg.mozilla.org/mozilla-central/rev/acfdfbb04139
https://hg.mozilla.org/mozilla-central/rev/c9517c3c6223