password-change doorhanger is shown when filling a generated password even if the form login has a username
Categories
(Toolkit :: Password Manager, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox-esr68 | --- | unaffected |
firefox68 | --- | unaffected |
firefox69 | --- | disabled |
firefox70 | --- | verified |
People
(Reporter: MattN, Assigned: MattN)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [passwords:generation] [skyline])
Attachments
(2 files)
Bug 1570485 - Show save doorhanger when we didn't auto-save and form username isn't empty. r=sfoster
47 bytes,
text/x-phabricator-request
|
Details | Review | |
57.96 KB,
image/png
|
Details |
STR:
- Save a login with an empty username for a site (to prevent auto-save of later generation)
- Visit a registration form
- Fill out the username field with a non-empty value
- Fill a generated password
Expected result:
- No auto-save since a login with no username exists
- no "saved" toast or blue key
- Prompt to save the login since it wasn't auto-saved
Actual result:
- No auto-save since a login with no username exists
- no "saved" toast or blue key
- Prompt to "update" the login even though it was never saved. The button indicates it will actually save, not update.
It seems like we missed this case in our automated coverage.
Assignee | ||
Comment 1•5 years ago
|
||
We shouldn't show an update doorhanger message if the default action is to save as a new login.
Comment 2•5 years ago
|
||
:MattN, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 3•5 years ago
|
||
Not sure if it is bug 1565409 but moving it from blocks to make bugbug happy…
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/d73bd536b663 Show save doorhanger when we didn't auto-save and form username isn't empty. r=sfoster
Comment 5•5 years ago
|
||
bugherder |
Comment 6•5 years ago
|
||
I have verified this fix on Nightly v70.0a1 from 2019-08-11 on Windows 10 and Mac OS 10.14.6.
When having a login for a website without a username (to prevent autosaving of a generated password) and then the user fills in a username and generates a password on the registration page of the same website, he will notice that the "Save" prompt is displayed, not the "Update". So far, so good, but, is the text correct?
"Would you like Nightly to save this login for google.com?"
Thanks.
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 7•5 years ago
|
||
(In reply to Bodea Daniel [:danibodea] from comment #6)
When having a login for a website without a username (to prevent autosaving of a generated password) and then the user fills in a username and generates a password on the registration page of the same website, he will notice that the "Save" prompt is displayed, not the "Update". So far, so good, but, is the text correct?
"Would you like Nightly to save this login for google.com?"
Sorry, I don't exactly understand the STR. In your STR is the user editing the fields in the doorhanger at all?
Comment 8•4 years ago
|
||
I was following the STR in comment 0. So in that specific case, the "Save" prompt would be displayed, not the "Update" prompt. This validates the fix, but I was asking about the text displayed on the prompt.
Assignee | ||
Comment 9•4 years ago
|
||
OK, yes the text is correct. The user should be prompted to save since it wasn't auto-saved IIUC. There is no special text for pwgen.
Updated•4 years ago
|
Updated•2 years ago
|
Description
•