1570502 - typo in aboutNetError.js: `failedCertInfo.erroCodeString`

Status: RESOLVED FIXED

(Firefox :: Security, defect, P5)

Description

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

https://searchfox.org/mozilla-central/rev/b38e3beb658b80e1ed03e0fdf64d225bd4a40327/browser/base/content/aboutNetError.js#750

should be failedCertInfo.errorCodeString ...

(this implies we don't have test coverage for this)

Comment 1

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 2

[Johann Hofmann [:johannh]]

Thanks for spotting this, but it isn't a bad issue IMO. It will only mean that pages that are affected by the Symantec distrust will get a yellow border instead of no yellow border. Most sites have migrated off at this point.

(this implies we don't have test coverage for this)

No, we don't have test coverage for the symantec distrust error page and I don't think it's worth adding some now. I don't think we would necessarily have tested this specific case (that it doesn't get the yellow border) anyway.

Comment 3

[Megha [ :meghaaa ]]

I would like to work on it, can I take this up?

Comment 4

[Johann Hofmann [:johannh]]

Hi Megha, I just assigned you to bug 1530781 and I think it's best to focus on a single bug for now. I'll happily assign you to this when you fix the other bug. You can still of course always submit a patch for this bug.

Comment 5

[Balraj]

Please assign this one to me.

Comment 6

[Johann Hofmann [:johannh]]

Sure, please let me know if you need any help!

Comment 7

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Happy to take a patch for 70; I'm just marking this fix-optional so that we don't need to keep triaging the bug every week.

Comment 8

[Balraj]

(In reply to Johann Hofmann [:johannh] from comment #6)

Sure, please let me know if you need any help!

Thanks. Sorry for my late reply.
Can you help me get started with getting the source code and building it? Where can I find it?

Comment 9

[Balraj]

Edit: I'm using macOS, so I found this https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Mac_OS_X_Prerequisites guide to getting the source and building instructions. Is that right?

Comment 10

[Johann Hofmann [:johannh]]

(In reply to Balraj from comment #9)

Edit: I'm using macOS, so I found this https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Mac_OS_X_Prerequisites guide to getting the source and building instructions. Is that right?

Yup, that should be right.

Comment 11

[Johann Hofmann [:johannh]]

Hey, are you still working on this or should I unassign you? :)

Thanks!

Comment 12

[Johann Hofmann [:johannh]]

Unassigning for inactivity, let me know if you want to pick this up again :)

Comment 13

[Kyle Kim]

Hi I am a computer science student from University of Toronto and I am interested in fixing this bug as part of my class project. Can I claim this bug? I am also looking for a mentor who can help me fixing this bug.

Comment 14

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Hi Kyle - I assigned you to the bug. Here's build instructions: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions
Here's more general information on contributing: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction
Let me know if you have any questions!

Comment 15

[Kyle Kim]

Hi Dana, Could you give me an advice on how to test my bugfix? I am little bit unclear on "Symantec distrust" and how to trigger it.
(In reply to Dana Keeler (she/her) (use needinfo) (:keeler for reviews) from comment #14)

Hi Kyle - I assigned you to the bug. Here's build instructions: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions
Here's more general information on contributing: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction
Let me know if you have any questions!

Comment 16

[Kyle Kim]

Attachment: Bug 1570502 - print hello kyle

Comment 17

[Kyle Kim]

Attachment: Bug 1570502 - Fixed typo erroCodeString to errorCodeString

Depends on D52491

Comment 18

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

To test this, you could run ./mach mochitest browser/base/content/test/about/browser_aboutNetError.js.
To specifically test the Symantec distrust handling, you could run the SanctionsTestServer[0], add symantec-not-whitelisted-after-cutoff.example.com to your hosts file, add the Symantec test CA [1] as a trusted certificate in Firefox, visit https://symantec-not-whitelisted-after-cutoff.example.com:8443, and check that there are no errors in the web console and the browser console. That's probably more work than necessary, though, since we can verify by inspection that this is correct.

[0] https://searchfox.org/mozilla-central/source/security/manager/ssl/tests/unit/tlsserver/cmd/SanctionsTestServer.cpp
[1] https://searchfox.org/mozilla-central/source/security/manager/ssl/tests/unit/test_sanctions/symantec-test-ca.pem

Comment 19

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:kskim.kim, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c60ff4bc048
Fixed typo erroCodeString to errorCodeString r=keeler

Comment 21

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/4c60ff4bc048

Comment 22

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.