Closed Bug 1570513 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 18221 - [wpt] Smarter discovery of Chrome binaries

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18221 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18221
Details from upstream follow.

Robert Ma <robertma@chromium.org> wrote:

[wpt] Smarter discovery of Chrome binaries

Previously, the default binary path for Chrome was hard-coded regardless
of the channel, making it cumbersome to test non-stable channels (in
addition to --channel, users had to specify --binary). With this
change, ./wpt run tries to find the channel-specific binary in lieu of
the --binary argument:

  • On Linux, find google-chrome-{stable,beta,unstable} in PATH.
  • On Mac, find "Google Chrome{, Canary}.app".

(Compatible with the official Linux and macOS packages)

This change does not affect existing CI setups, because we always
specify --binary on CI.

Also update the doc to reflect the change.

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e12f279e065c [wpt PR 18221] - [wpt] Smarter discovery of Chrome binaries, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e12f279e065c

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.