1570515 - clang toolchain build logs are essentially empty

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect)

Description

[Mike Hommey [:glandium]]

Bug 1546136 wrapped process execution logs to capture cmake output. But it did so by capturing the output of all subprocesses. And their output is only printed out if they are failures (also, stderr is hidden entirely).

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1570515 - Change how build-clang.py consumes subprocess output.

Bug 1546136 wrapped subprocess execution output to capture cmake's, but
at the detriment of other output, and hiding everything unless an error
occurs.

So instead, we only capture the output when the called process is cmake,
and even when it is cmake, we don't pipe stderr at all (since we only
care about cmake's stdout) and we print out stdout as it comes in rather
than later. We then later check the output for hints at the more useful
cmake logs and dump them.

While here, add verbosity to ninja output (which gives the command
lines, rather than generic "Building foo.o" output).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ef2d2e3f4b9
Change how build-clang.py consumes subprocess output. r=froydnj

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6ef2d2e3f4b9