Closed Bug 1570548 Opened 5 years ago Closed 5 years ago

Crash @ mozilla::WebrtcMediaDataDecoder::Release on Redhat7.5

Categories

(Core :: Audio/Video: Playback, defect, P2)

70 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: yanfzhen, Assigned: dminor)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Starts an Webex Meeting with chrome browser, send video.
Join a attendee using firefox 68.0.1 from Redhat 7.5 64bit

Actual results:

FIrefox should receive the video from chrome

Expected results:

FIrefox crashes at mozilla::WebrtcMediaDataDecoder::Release
below is the crash link:
https://crash-stats.mozilla.org/report/index/ec05ddf5-f39e-4329-a181-1fe320190801
https://crash-stats.mozilla.org/report/index/5b411cd5-f52d-4c83-960b-b9ff50190801
https://crash-stats.mozilla.org/report/index/ec05ddf5-f39e-4329-a181-1fe320190801
https://crash-stats.mozilla.org/report/index/d975b841-0d7d-4632-a58b-5c89b0190801

Summary: Crash @ mozilla::WebrtcMediaDataDecoder::Release → Crash @ mozilla::WebrtcMediaDataDecoder::Release on Redhat7.5

I tested this issue on Ubuntu 18.04.2 64bit and i was not able to reproduce the problem.

Testes following versions:
Nigthly 70.0a1
Beta 69.0b10
Release 68.0.1

Please download Firefox Nightly from here: https://nightly.mozilla.org/ and retest the problem.

If you still have the issue please create a new profile, you have the steps here:https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?redirectlocale=en-US&redirectslug=Managing-profiles#w_starting-the-profile-manager

Lastly test if the issue is reproducible in safe mode, here is a link that can help you:
https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

Regards
Pablo

Added component Audio/video Playback

Component: Untriaged → Audio/Video: Playback
Product: Firefox → Core

Thank you for reporting this bug! Based upon the rest of the code in this file, it looks like mDecoder can be null if initialization failed and we need to check if decoder is null here [1].

[1] https://searchfox.org/mozilla-central/rev/a650fac7b069ded3d63eba530271ce80e6cafb1b/media/webrtc/signaling/src/media-conduit/WebrtcMediaDataDecoderCodec.cpp#153

Assignee: nobody → dminor
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P2
Version: 68 Branch → 70 Branch

In InitDecode it is possible for mDecoder to be null if the CreateDecoder call
fails, in which case an error code is returned. Release is called by
GenericDecoder::~VCMGenericDecoder regardless of whether InitDecode succeeds, so
we need to check if mDecoder is null in Release.

Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b59b10f73859
Check if mDecoder is null in WebrtcMediaDataDecoder::Release; r=bryce
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

The fix should now be on Nightly. If you have a chance, could you please test this again and see if this fixed things? Thank you!

Flags: needinfo?(yanfzhen)

(In reply to Dan Minor [:dminor] from comment #8)

The fix should now be on Nightly. If you have a chance, could you please test this again and see if this fixed things? Thank you!

Yes I have tried the nightly version (71.0a1) of firefox on redhat, the crash issue is fixed. But I met another issue:
When try to receive the video from others, in firefox console will have error: AbortError: The fetching process for the media resource was aborted by the user agent at the user's request. Do you know how to fix this?

Flags: needinfo?(yanfzhen)

(In reply to yanfzhen from comment #9)

(In reply to Dan Minor [:dminor] from comment #8)

The fix should now be on Nightly. If you have a chance, could you please test this again and see if this fixed things? Thank you!

Yes I have tried the nightly version (71.0a1) of firefox on redhat, the crash issue is fixed. But I met another issue:
When try to receive the video from others, in firefox console will have error: AbortError: The fetching process for the media resource was aborted by the user agent at the user's request. Do you know how to fix this?

Thank you for testing this. I'm sorry, I don't know what would cause the error you are seeing now. If you think it may be a problem with Firefox, please file a new bug and hopefully someone else will be able to help out.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: