Closed Bug 157057 Opened 23 years ago Closed 23 years ago

Full-page plugins don't work for static builds

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: bryner, Assigned: bryner)

Details

Attachments

(1 file, 1 obsolete file)

more cleanup
12.03 KB, patch
peterlubczynski-bugs
: review+
shaver
: superreview+
chofmann
: approval+
Details | Diff | Splinter Review
The registration of DocLoaderFactories for plugin mime types depends on the plugin module being an actual shared library. In a static build, this is not the case, so we fail to register the factory and prompt the user to save the file instead of showing the full-page plugin.
Attached patch patch (against the trunk) (obsolete) — — Splinter Review
Comment on attachment 91082 [details] [diff] [review] patch (against the trunk) Well doesn't _that_ look a heck of a lot nicer than before? sr=shaver, with gusto!
Attachment #91082 - Flags: superreview+
Comment on attachment 91082 [details] [diff] [review] patch (against the trunk) r=peterl Not that this is in any way part of this bug, but in reviewing this patch I noticed that we never call |nsIComponentRegistrar::UnregisterFactory|. This may be needed in a run-time upgrade or uninstallation -- when |ReloadPlugins| is called and our list of pluginTags have changed.
Attachment #91082 - Flags: review+
Should obsoleteManager be completely excised from nsPluginHostImpl.cpp now? This patch leaves references to it (e.g. "if (NS_SUCCEEDED(rv) && compManager && obsoleteManager) ")
Attached patch more cleanup — — Splinter Review
Just eliminating some more variables and function parameters that are no longer necessary.
Attachment #91082 - Attachment is obsolete: true
Comment on attachment 91148 [details] [diff] [review] more cleanup sr=shaver.
Attachment #91148 - Flags: superreview+
Comment on attachment 91148 [details] [diff] [review] more cleanup r=peterl
Attachment #91148 - Flags: review+
Comment on attachment 91148 [details] [diff] [review] more cleanup a=chofmann for 1.1b
Attachment #91148 - Flags: approval+
Checked into the trunk and the Chimera branch.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
full page plugins (flash,qktime) have been verified to work on chimera and osx builds. marking this verif.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: