1570575 - Some libpref clean-ups

Status: RESOLVED FIXED

(Core :: Preferences: Backend, task)

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570575 - Some libpref tidy-ups. r=KrisWright

This commit:

• improves the wording of some comments;

• renames UpdatePolicy as MirrorKind, to reflect the new terminology we are
  starting to use;

• does a couple of other minor clean-ups.

Depends on D40151

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1570575 - Remove `MirrorKind`. r=KrisWright

This commit removes MirrorKind by splitting the VARCACHE_PREF macros in
two, giving ALWAYS_PREF and ONCE_PREF macros. This is good because most of
the time the generated code is quite different for the two cases.

The commit also removes the examples of code produced by the macros in
comments. These are kind of useful, but also quite verbose and a pain to
maintain.

Depends on D40161

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/677bcc847e07
Some libpref tidy-ups. r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/89b4edfa8150
Remove `MirrorKind`. r=KrisWright

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/677bcc847e07
https://hg.mozilla.org/mozilla-central/rev/89b4edfa8150