Rename DebuggerClient.getActor to getFront
Categories
(DevTools :: Framework, task, P3)
Tracking
(firefox70 fixed)
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
DebuggerClient exposes a method to retrieve the Front (or client if we still have some) for a given actor whose ID is passed as argument:
https://searchfox.org/mozilla-central/source/devtools/shared/client/debugger-client.js#926-929
This naming is surprising as you would expect to retrieve an Actor instance.
This work relates to bug 1478973, where we do expose get and actor to retrieve something from a Pool. In that bug, we would like to get rid of the too generic get method.
But that would mean that here, in debugger-client.js, we would have to call
pool.actor(actorID). Should we then have both actor and a front methods?
The confusion comes from the fact that Pool is used by both client and server side...
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
In the current patch, I renamed it to getFront in place of getActor, but may be that would be cleared if we name it getFrontById in order to distinguish from TargetMixin.getFront, which accept a typeName instead of an ID?
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/598aa6ad2c74 Rename DebuggerClient.getActor to getFrontByID. r=jdescottes,yulia
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Description
•