Closed Bug 1570634 Opened 1 year ago Closed 1 year ago

Renew expired media telemetry

Categories

(Core :: Audio/Video, enhancement, P2)

70 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox69 --- fixed
firefox70 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

Details

Attachments

(2 files)

In Bug 1561923 and Bug 1356046 we're removing expired telemetry for media playback and WebRTC. As part of this process, we've identified probes we would like to renew. This bug will track renewing those probes.

Attached is a renewal request for expired media related telemetry probes. In the bugs mentioned above, I prepared patches to remove all of the expired telemetry and then restored the telemetry that my reviewers thought was still relevant.

At least one person requested that we keep each telemetry probe mentioned in this request, so there is some background on why we want to keep them around in the associated reviews. Please let me know if the justifications for keeping them need to be part of the document here as well.

I'm on PTO next week, I'll plan to put together a patch for the renewals when I return. I was planning to set the expiration version for all of the probes to Firefox 74, except for the handful mentioned in the document that we would like to have never expire.

Thanks for having a look!

Attachment #9082707 - Flags: data-review?(chutten)
Comment on attachment 9082707 [details]
media-telemetry.renewal.md

PRELIMINARY NOTES:
This is a Data Collection Review for 21 probes all at once (17 temporary, 4 permanent). That's a lot for a single review. Can you please confirm that all of the probes are required to answer the questions posed in 1? A good test is "Would a user with questions about why we're collecting that probe be satisfied with the questions we identify in the review".

To be clear: "Yup, we're good" is a perfectly reasonable response for this question : )

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

For VIDEO_DROPPED_FRAMES_PROPORTION , VIDEO_HIDDEN_PLAY_TIME, VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE, and VIDEO_PLAY_TIME, drno and jya are responsible.

The rest of the collections will expire in six months.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

For the non-permanent collections: dminor is responsible for renewing or removing the collection before they expires in six months.

---
Result: datareview+
Flags: needinfo?(dminor)
Attachment #9082707 - Flags: data-review?(chutten) → data-review+

We ended up removing around 75 expired probes prior to filing this bug, so we've been fairly selective about what we want to renew. I'm not familiar with the technical details of every probe in the list, but for each probe we're renewing, we had at least one person ask for it to be renewed during code review during the removal process, so I think the answer is, yup, we're good here :).

Flags: needinfo?(dminor)
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4137f96eb02
Renew expired media telemetry; r=chutten
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Comment on attachment 9084805 [details]
Bug 1570634 - Renew expired media telemetry; r=chutten

Beta/Release Uplift Approval Request

  • User impact if declined: No direct user impact, but having the telemetry renewed in 69 would make it easier for us to use the data to prioritize future work, meaning we can focus on areas that are most relevant to our users.
  • Is this code covered by automated tests?: Unknown
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Low risk, this only renews expired telemetry probes.
  • String changes made/needed: None
Attachment #9084805 - Flags: approval-mozilla-beta?

Comment on attachment 9084805 [details]
Bug 1570634 - Renew expired media telemetry; r=chutten

Extends an expired media telemetry probes. Approved for 69.0b14.

Attachment #9084805 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I tried to uplift this to beta but got conflicts:
grafting 560139:f4137f96eb02 "Bug 1570634 - Renew expired media telemetry; r=chutten"
merging toolkit/components/telemetry/Histograms.json
merging toolkit/components/telemetry/Scalars.yaml
warning: conflicts while merging toolkit/components/telemetry/Histograms.json! (edit, then use 'hg resolve --mark')
warning: conflicts while merging toolkit/components/telemetry/Scalars.yaml! (edit, then use 'hg resolve --mark')

You need to log in before you can comment on or make changes to this bug.