Add startup.profile_selection_reason scalar to new profile ping
Categories
(Toolkit :: Telemetry, enhancement, P1)
Tracking
()
People
(Reporter: janerik, Assigned: janerik)
References
Details
Attachments
(4 files)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-release+
|
Details | Review |
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-release+
|
Details | Review |
1.65 KB,
text/plain
|
tdsmith
:
data-review+
|
Details |
1.65 KB,
text/plain
|
tdsmith
:
data-review+
|
Details |
This bug is for implementing putting scalars into the new-profile-ping and adding the startup.profile_selection_reason
to it (while also keeping it in the main ping).
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Depends on D40595
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
Here's the patch for adding scalars to the new profile ping as well as adding the one metric you want. I also did the data collection review request
However, the data is set to expire in version 72. That is rather soon. Do you want to extend it? If so I can just do that in the same patch and data collection review.
Comment 5•5 years ago
|
||
Comment 6•5 years ago
|
||
Comment 7•5 years ago
|
||
(In reply to Jan-Erik Rediger [:janerik] from comment #4)
Here's the patch for adding scalars to the new profile ping as well as adding the one metric you want. I also did the data collection review request
However, the data is set to expire in version 72. That is rather soon. Do you want to extend it? If so I can just do that in the same patch and data collection review.
Yeah I'd say we should extend it given how soon it's expiring. I'm not sure how the extension process works in terms of when to extend to / who decides. Let me know if I need to do involve someone and I will.
Comment 8•5 years ago
|
||
From data stewardship's POV: extending it six months (about five versions) is typical.
Assignee | ||
Comment 9•5 years ago
|
||
Tim, would you be so kind to acknowledge the expiry extension in the data review. Thanks! (Nothing else in there changed, the code patch is also changed now)
Comment 10•5 years ago
|
||
Comment 11•5 years ago
|
||
Comment 12•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4da46fd56311
https://hg.mozilla.org/mozilla-central/rev/674426059fcc
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 13•5 years ago
|
||
Comment on attachment 9082949 [details]
Bug 1570652 - Add profile_selection_reason to the new-profile ping store
Beta/Release Uplift Approval Request
- User impact if declined: This data would be very beneficial to have in 69, before the Skyline release (70) to iron out any possible issues before that.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Landed in nightly last week and we verified data is coming in.
The change itself is covered by automatic tests. - String changes made/needed:
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 14•5 years ago
|
||
(I shouldn't reopen bugs for uplift-requests, therefore closing again, uplift request stays relevant)
Comment 15•5 years ago
|
||
Comment on attachment 9082948 [details]
Bug 1570652 - Include scalars in new-profile ping
Improves new-profile telemetry to help find issues ahead of the Skyline release. Approved for 69.0rc1.
Updated•5 years ago
|
Comment 16•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-release/rev/7808d12b32c2
https://hg.mozilla.org/releases/mozilla-release/rev/177d61eccf2d
Description
•