Closed Bug 1570661 Opened 5 years ago Closed 5 years ago

Crash upon session restore

Categories

(Firefox for Android Graveyard :: General, defect, P1)

Unspecified
Android
defect

Tracking

(firefox-esr60 unaffected, firefox-esr68 unaffected, firefox68 unaffected, firefox69 unaffected, firefox70 verified)

VERIFIED FIXED
Firefox 70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- verified

People

(Reporter: andrei.a.lazar, Assigned: snorp)

References

Details

(Keywords: crash, regression)

Crash Data

Attachments

(2 files)

Steps to reproduce:

  1. visit a website
  2. go to settings->privacy
  3. change Tracking Protection-> to Enabled
  4. go back to your currently open tab

Expected result:
A tab with the visited website should be shown

Actual result:
App is crashing

I have attached a log with the stacktrace.
Chris, can you set the right flags for this, please?

Flags: needinfo?(cpeterson)

James, could your recent open/closed session fixes (GeckoSession bug 1510314) have caused this new reproducible crash in Fennec 70?

Flags: needinfo?(cpeterson) → needinfo?(snorp)
Keywords: crash
Priority: -- → P1
Whiteboard: [geckoview]?

I did change some stuff here, but this particular case would've crashed before my changes as well.

Flags: needinfo?(snorp)

Oh hmm, actually I'm not sure about that now. I'll investigate some.

Component: General → Session Restore

Not "Session Restore" as such, despite the similar sounding names.

Component: Session Restore → General
Crash Signature: [@ java.lang.IllegalStateException: at org.mozilla.geckoview.GeckoView.setSession(SourceFile:349)]
Attachment #9083683 - Attachment description: Bug 1570661 - Don't use GeckoView state management in Fennec → Bug 1570661 - Don't save GeckoView state in Fennec
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/473f134e1cc3
Don't save GeckoView state in Fennec r=geckoview-reviewers,droeh
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Assignee: nobody → snorp

Hi!
This was reproducible also with the following steps:

  1. Launch Fennec;
  2. Go to Menu -> Settings -> Mozilla Nightly -> About Nightly;

I tested this on the latest version of Nightly 70.0a1 (2019-08-07) with Samsung Galaxy Note 8 (Android 9) and the browser does not crash anymore with any of the STR's, but I have noticed that the about:firefox page is not displayed. I filed Bug 1572359 for this issue.
I will mark this as verified on Firefox 70.
Thanks!

Status: RESOLVED → VERIFIED
Regressions: 1572359

Ho hum... instead of a crash we're now back at bug 1494748, which isn't really an improvement.

(In reply to Jan Henning [:JanH] from comment #10)

Ho hum... instead of a crash we're now back at bug 1494748, which isn't really an improvement.

@ Jan, should we reopen this bug or file a new bug for the frozen content problem?

@ Andrei, does this crash only affect Fennec 70? Or do we need to uplift this crash fix to Fennec ESR 68? James' fix for GeckoSession bug 1510314 is only in 70.

Flags: needinfo?(jh+bugzilla)
Flags: needinfo?(andrei.a.lazar)
Whiteboard: [geckoview]?

should we reopen this bug or file a new bug for the frozen content problem?

There already is bug 1572359 for that.

Flags: needinfo?(jh+bugzilla)

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression

If bug 1510314 is only in 70 then I don't think we need to uplift to ESR.

Flags: needinfo?(andrei.a.lazar)

(In reply to Andrei Lazar from comment #14)

If bug 1510314 is only in 70 then I don't think we need to uplift to ESR.

Cool. In that case, I will set this bug's status flags for firefox <= 69 to unaffected. No uplift needed.

Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: