1570679 - Participant tooltip doesn't appear when hovering a nick in conversation

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[WaltS48 [:walts48]]

Sign into a chat account
Enter a channel
Wait for some conversation to appear
Hover the mouse pointer over a participants nick to view the tooltip information

Nothing appears in TB 69.0b1 or Daily 70.0a1. Works in 68.0b5

Tooltip information should appear since TB 29.0 with the port of bug 955121 in bug 956579.

Comment 1

[Wayne Mery (:wsmwk)]

Walt, thanks for the CC

Comment 2

[Jorg K (CEST = GMT+2)]

Thank goodness it works in TB 68. I can confirm that hovering the participants nick in the conversation in the middle doesn't work, but it works when hovering it in the list on the side.

STR as per comment #0:
Sign into a chat account
Enter a channel, for example |test| (without the |)
Type something so your own nick appears in the conversation in the middle.
Hover the mouse pointer over a participants nick to view the tooltip information

Alice, can you please find the regression for us.

I believe you've worked on chat bugs for us before, so you should be familiar with the details, like IRC, irc.mozilla.org, etc. I didn't know that you can create your own channel, like "test" to not disturb people in other channels.

Comment 3

[Jorg K (CEST = GMT+2)]

Thanks for looking, Alice, you can join chat room "test" and even connect on the next start automatically.

Comment 4

[Alice0775 White]

#1 Crash Thunderbird when connect to chat account:
https://crash-stats.mozilla.com/report/index/5828bafc-c9b2-4882-b2c3-2aa4e0190803
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=3e76c29bfb96ce9f785f63c4d2adb318f3664dbf&tochange=ae1624177e2cf555a9d1f35bcae4c2e6287545bc
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d72ab884f0394d6e9ab723f03bd43c90a84d7e5b&tochange=7445a65187306dfa0fc18492e7b198887a146b18

#2 Fix the crash. However, tooltip also stop to popup:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=83dd4afa641fe1128d23b004fc59d97d2829f974&tochange=8da790400467339fff4f0954284c9ac69b98c7e8
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ac50a7bd09b0a9262eed73f9dee2ffbd0e1a33b2&tochange=2b1bee2c77347e39b4a6f0023cf1a7dabc4db607

So, Regression window is:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=3e76c29bfb96ce9f785f63c4d2adb318f3664dbf&tochange=8da790400467339fff4f0954284c9ac69b98c7e8
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d72ab884f0394d6e9ab723f03bd43c90a84d7e5b&tochange=2b1bee2c77347e39b4a6f0023cf1a7dabc4db607

Comment 5

[Jorg K (CEST = GMT+2)]

Thanks you so much, Alice.

Yes, right, there was that crash in chat that we fixed in bug 1559523. That was caused by bug 1552049 which is in your first range.
Yes, bug 1559523 was fixed in the second range.

So the regression window doesn't help us here at all. Just proves the point that if you leave something broken for a while, you can't detect other failures that add up in the meantime.

I guess it went broken by some chat or de-XBL activities, so NI'ing the people in charge of that.

Comment 6

[Alice0775 White]

FYI, Regression window via local build with patch of bug 1559523:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=3648eae49455f36ca2da8c70f9c016316dc6c2e0&tochange=d49c04d9b70e7493bd5c6938b5045ead17659a59
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4cde299454c9851a32d555ce7004f2f69457ecb3&tochange=4cde299454c9851a32d555ce7004f2f69457ecb3

Comment 7

[Jorg K (CEST = GMT+2)]

Fantastic, thank you so much!!!

Comment 8

[Alessandro Castellani [:aleca]]

Thanks for finding the regression.
I'm on it!

Comment 9

[Magnus Melin [:mkmelin]]

Taking this.

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: bug1570679_chat-conversation.part1.patch

Get rid of the "chat" attribute, apparently only used to hide/show the context pane (the one on the right of chats).

Comment 11

[Magnus Melin [:mkmelin]]

Attachment: bug1570679_chat-conversation.part2.patch

FIxing the convbrowser inherits=, but removing some pointless redirections.

Comment 12

[Jorg K (CEST = GMT+2)]

Comment on attachment 9086618 [details] [diff] [review]
bug1570679_chat-conversation.part1.patch

Let's not forget beta for this.

Comment 13

[Alessandro Castellani [:aleca]]

Comment on attachment 9086618 [details] [diff] [review]
bug1570679_chat-conversation.part1.patch

Review of attachment 9086618 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and it works.

Comment 14

[Jorg K (CEST = GMT+2)]

Comment on attachment 9086618 [details] [diff] [review]
bug1570679_chat-conversation.part1.patch

Also for the other part.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/429c14cec21a
for chat-conversation, remove usage of "chat" attribute. r=aleca
https://hg.mozilla.org/comm-central/rev/82a3ba630c6d
fix de-xbl fallout to make tooltips work for content in the conversation-browser. r=aleca

Comment 16

[Magnus Melin [:mkmelin]]

Ah, part 1 had the logic backwards and slightly wrong.

Comment 17

[Magnus Melin [:mkmelin]]

Attachment: bug1570679_chat.part1followup.patch

Comment 18

[Jorg K (CEST = GMT+2)]

Hmm, just when I wanted to prepare our next beta. It was working though, right? I tried it before landing.

Comment 19

[Magnus Melin [:mkmelin]]

The tooltip yes (part2), but part1 was wrong.

Comment 20

[Alessandro Castellani [:aleca]]

Comment on attachment 9086965 [details] [diff] [review]
bug1570679_chat.part1followup.patch

Review of attachment 9086965 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, and kudos for the improvement.

Comment 21

[Jorg K (CEST = GMT+2)]

I know what to land, I didn't start this job yesterday ;-)

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/df168bc6b77d
follow-up to fix backward logic for the "chat" attribute removal. r=aleca

Comment 23

[Jorg K (CEST = GMT+2)]

TB 69 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/7b046aa7c4afc118571eafe4674d3ae65d83558b
https://hg.mozilla.org/releases/comm-beta/rev/0e0b6fb625ce7dd891cc83e926d38296c4e85bc5
https://hg.mozilla.org/releases/comm-beta/rev/da67254eae57f956d8bef5ed564f4975a29c0c5a