1570685 - Bug 1452920 broke backward compatibility by at least changing startListeners packets

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Alexandre Poirot [:ochameau]]

Bug 1452920 changed the format of startListeners packet, from:

{ listeners: [..] }

to

{ events: [..] }

Leading to broken console when connecting to older version of Firefox.

This may have change something else as, even after fixing that, I do not get a working console input.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1570685 - Revert startListeners, stopListeners, autocomplete and evaluateJSAsync requests to the previous format.

Bug 1570685 changed the format of the startListeners request,
leading to backward compatiblity issues.

Comment 2

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fdfa1664fb2d1abe7da2d0a42a487f6c3bb114e

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1570685 - Only resolve DomPanel.open once the properties are updated.

This relates to bug 1566421, where the timing around DOM panel instantiation changed.
Since that patch landed, the full initialization of DOM Panel looks faster.
The FETCH_PROPERTIES action doesn't necessarily happen after domPanel.open()
resolves. i.e. it can happen during during this method call.
Now this patch, as well as some other I'm currently working on are changing
that behavior again and adding some delay in DOM panel initialization.

So, here I'm trying to fix things for good by ensuring that domPanel.open
only resolves once it loaded all the properties and will not spawn any
extra RDP request. Ideally I would listen for FETCH_PROPERTIES action,
but that isn't so easy. Instead, I waiting for the last RDP request to complete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1175ce1c32a0
Revert startListeners, stopListeners, autocomplete and evaluateJSAsync requests to the previous format. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/084da3830f44
Only resolve DomPanel.open once the properties are updated. r=nchevobbe,jdescottes,Honza

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1175ce1c32a0
https://hg.mozilla.org/mozilla-central/rev/084da3830f44