1570743 - Set up Thunderbird CI for macOS 10.14 testing

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, task, P2)

Description

[Rob Lemley [:rjl]]

There's a number of bugs to look at and port on the Firefox side, starting with bug 1550826 that added the initial support for testing on macOS 10.14.

Bug 1555454 covers xpcshell, mochitest, and marionette tests

mozmill tests will be more fun.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Patch 1 - enable_macos1014_tests.patch

This just adds the underlying pieces needed to enable tests on macOS 10.14.
Safe to land now.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Patch 2 - split_tests_by_type.patch

I'm guessing that there will be some issues with some tests when
moving them to macOS 10.14, so this splits out the tests by type
so xpcshell for example can be enabled on 1014 without getting
mozmill.
This also makes the names a more consistent since we had "common",
"optimized" (mochitest), and "marionette".

This doesn't enable any new tests yet, just sets the foundation
to do so.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9082412 [details] [diff] [review]
Patch 1 - enable_macos1014_tests.patch

Review of attachment 9082412 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/ci/test/test-platforms.yml
@@ +106,5 @@
>      test-sets:
>          - common-tests
>          - optimized-tests
> +
> +#macosx1014-64/debug:

Why add comments?

Comment 4

[Rob Lemley [:rjl]]

Try jobs running with 1014 tests enabled to see how things look:

xpcshell, mochitest:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c35bd41588160f1db2285115e811994a4770a30d

mozmill:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=edc2b4077e57745baca382bb4446bbe9365c9eee

Comment 5

[Rob Lemley [:rjl]]

(In reply to Jorg K (GMT+2) from comment #3)

Comment on attachment 9082412 [details] [diff] [review]
Patch 1 - enable_macos1014_tests.patch

Review of attachment 9082412 [details] [diff] [review]:

Why add comments?

I figure these won't work on the first run (see try jobs in comment 4), so this would allow work to happen on the test suites on try builds without breaking c-c.

Comment 6

[Geoff Lankow (:darktrojan)]

(In reply to Rob Lemley [:rjl] from comment #2)

I'm guessing that there will be some issues with some tests when
moving them to macOS 10.14, so this splits out the tests by type
so xpcshell for example can be enabled on 1014 without getting
mozmill.

What sort of issues are you expecting? It appears they all work and pass apart from the usual flakiness.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b575958cf824
Port bug 1550826: Thunderbird tests on macOS 10.14 in CI. r=darktrojan

Comment 8

[Jorg K (CEST = GMT+2)]

Folded both patches into one but without the comments. Instead I changed 1010 to 1014 to make the local mach taskgraph full happy since the D was red. If you don't like it, land a follow-up, anything goes as long as there is a hyphen ;-)

Comment 9

[Jorg K (CEST = GMT+2)]

And no:
20:24:11 - rjl: okay. i'd rather not land the whole enabling 1014 on a friday night if possible.
wasn't possible.

Comment 10

[Rob Lemley [:rjl]]

Works for me. Thanks!