Closed Bug 1570772 Opened 4 months ago Closed 2 months ago

License linter is missing a task

Categories

(Firefox Build System :: Lint and Formatting, task)

task
Not set

Tracking

(firefox70 fixed, firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(8 files)

There's no task to cause failures for missing license headers. I see 385 lint errors on the latest mozilla-central. We should fix/exclude these and add a task so more files with missing licenses don't get added.

See Also: → 1562642
Assignee: nobody → ahal
Status: NEW → ASSIGNED
Keywords: leave-open

Hey Sylvestre, I have a patch series here that adds a task by adding paths with missing licenses to the exclude list. Though I notice you are getting them added in bug 1562642. Should I block on that instead of updating the exclude list? Or want me to just go ahead with excluding in the meantime.

Flags: needinfo?(sledru)

whatever is the easier for you, I will adjust :)

Flags: needinfo?(sledru)
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/95cb06045cfc
[lint] Don't enforce licenses in empty files, r=sylvestre
https://hg.mozilla.org/integration/autoland/rev/e390027ffcc7
[lint] Add the root 'node_modules' to the GLOBAL_EXCLUDES list, r=sylvestre
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c0e88788302
[lint.license] Fix or exclude errors under /build r=firefox-build-system-reviewers,mshal
https://hg.mozilla.org/integration/autoland/rev/c68f078e58f6
[lint.license] Exclude errors under /devtools r=jlast
https://hg.mozilla.org/integration/autoland/rev/bbfab97110fa
[lint.license] Exclude pre-existing license errors r=sylvestre
https://hg.mozilla.org/integration/autoland/rev/d2fc2720837c
[ci] Add a task to run the license linter r=sylvestre
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f0e843f33a5f
Revert accidental changes to ThirdPartyPaths.txt from bad merge r=Mardak
Regressions: 1578362
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1eab9fe4ffbc
Fix license text for some files. r=ahal
Keywords: leave-open
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.