1570772 - License linter is missing a task

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Andrew Halberstadt [:ahal]]

There's no task to cause failures for missing license headers. I see 385 lint errors on the latest mozilla-central. We should fix/exclude these and add a task so more files with missing licenses don't get added.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1570772 - [lint] Don't enforce licenses in empty files, r?Sylvestre

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1570772 - [lint] Add the root 'node_modules' to the GLOBAL_EXCLUDES list, r?Sylvestre

Depends on D41755

Comment 3

[Andrew Halberstadt [:ahal]]

Hey Sylvestre, I have a patch series here that adds a task by adding paths with missing licenses to the exclude list. Though I notice you are getting them added in bug 1562642. Should I block on that instead of updating the exclude list? Or want me to just go ahead with excluding in the meantime.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

whatever is the easier for you, I will adjust :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95cb06045cfc
[lint] Don't enforce licenses in empty files, r=sylvestre
https://hg.mozilla.org/integration/autoland/rev/e390027ffcc7
[lint] Add the root 'node_modules' to the GLOBAL_EXCLUDES list, r=sylvestre

Comment 6

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1570772 - [lint.license] Fix or exclude errors under /build

Comment 7

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1570772 - [lint.license] Exclude errors under /devtools

Depends on D41820

Comment 8

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1570772 - [lint.license] Exclude pre-existing license errors

Depends on D41821

Comment 9

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1570772 - [ci] Add a task to run the license linter

Depends on D41822

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/95cb06045cfc
https://hg.mozilla.org/mozilla-central/rev/e390027ffcc7

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c0e88788302
[lint.license] Fix or exclude errors under /build r=firefox-build-system-reviewers,mshal
https://hg.mozilla.org/integration/autoland/rev/c68f078e58f6
[lint.license] Exclude errors under /devtools r=jlast
https://hg.mozilla.org/integration/autoland/rev/bbfab97110fa
[lint.license] Exclude pre-existing license errors r=sylvestre
https://hg.mozilla.org/integration/autoland/rev/d2fc2720837c
[ci] Add a task to run the license linter r=sylvestre

Comment 12

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1570772 - Revert accidental changes to ThirdPartyPaths.txt from bad merge

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0e843f33a5f
Revert accidental changes to ThirdPartyPaths.txt from bad merge r=Mardak

Comment 14

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/6c0e88788302
https://hg.mozilla.org/mozilla-central/rev/c68f078e58f6
https://hg.mozilla.org/mozilla-central/rev/bbfab97110fa
https://hg.mozilla.org/mozilla-central/rev/d2fc2720837c
https://hg.mozilla.org/mozilla-central/rev/f0e843f33a5f

Comment 15

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6c0e88788302
https://hg.mozilla.org/releases/mozilla-beta/rev/c68f078e58f6
https://hg.mozilla.org/releases/mozilla-beta/rev/bbfab97110fa
https://hg.mozilla.org/releases/mozilla-beta/rev/d2fc2720837c
https://hg.mozilla.org/releases/mozilla-beta/rev/f0e843f33a5f

Comment 16

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1570772 - Fix license text for some files. r=ahal

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1eab9fe4ffbc
Fix license text for some files. r=ahal

Comment 18

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/1eab9fe4ffbc