ScrollFrameHelper::UpdateMinimumScaleSize should be called whenever ScrollReflowInput::mContentsOverflowAreas.ScrollableOverflow() is changed
Categories
(Core :: Layout: Scrolling and Overflow, defect, P3)
Tracking
()
People
(Reporter: hiro, Assigned: hiro)
References
(Blocks 1 open bug)
Details
In bug 1423013, I did introduce mMinimumScaleSize in ScrollFrameHelper that is calculated in UpdateMinimumScaleSize() with ScrollReflowInput::mContentsOverflowAreas.ScrollableOverflow().
In that bug, I thought I did put the only one call site of UpdateMInimumScaleSize into the place where we've done updating ScrollReflowInput::mContentsOverflowAreas. But there seems some edge cases where we don't properly calculate mMinimumScaleSize. Because we update ScrollReflowInput::mContentsOverflowAreas in ReflowScrolledFrame and ReflowScrolledFrame is also called in Trylayout and TryLayout is called after we call UpdateMinimumScaleSize()...
I will try to write test cases.
|
Assignee | |
Comment 1•6 years ago
|
||
It seems to me that the case where the ScrollReflowInput::mContentsOverflowAreas is changed in the ReflowScrolledFrame call in TryLayout is that only when we need to layout scrollbars. In other words the difference of the overflow area changes is vertical scrollbar width and/or horizontal scrollbar height. That means that in overlay scrollbars environment, it doesn't matter at all.
Closing as INVALID. :)
Description
•