157083 - Autocomplete advanced window too small if none of the checkboxes are checked

Status: VERIFIED FIXED

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Steps to reproduce:

1. Go to Preferences->Navigator->Smart Browsing
2. Click "Advanced..."
3. Uncheck *all* checkboxes
4. Restart browser
5. Go to Preferences->Navigator->Smart Browsing
6. Click "Advanced..."

The advanced dialog will now be too small

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

I've got a patch for this which I'll upload shortly.

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Created attachment 91163 [details] [diff] [review]
Fix v1

So what happens is when no items are checked, our vbox initially starts out
with an image with no src attribute, and 2 hidden images since we end up hiding
them via JS.  We then apply the image src after we load the page, but by then
the dialog is already sized wrongly.  Placing an explicit min-width style here
will work.  The image is 401px wide so that's what I set min-width to.

Comment 3

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Comment on attachment 91163 [details] [diff] [review]
Fix v1

r=bzbarsky

Comment 4

[Blake Ross]

Comment on attachment 91163 [details] [diff] [review]
Fix v1

sr=blake

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 91163 [details] [diff] [review]
Fix v1

a=asa (on behalf of drivers) for checkin to the 1.1 trunk.

Comment 6

[Stephen Walker]

*** Bug 102692 has been marked as a duplicate of this bug. ***

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Fixed on trunk.

Comment 8

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2002.09.16.08 comm trunk builds.