Switch permissionsManager and cookieViewer to use Services.jsm
Categories
(SeaMonkey :: Passwords & Permissions, task)
Tracking
(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed, seamonkey2.63 wontfix)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.1)
Attachments
(2 files, 2 obsolete files)
|
23.61 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
|
23.57 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
As we still have cookieViewer and permissionsManager around we should switch them to fully use Services.jsm
Added a helper function for prompt service confirmation dialogs in cookieViewer so not repeating the same code in 4 places and removed the orphaned gDateService.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: None
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None
As frg pointed out I missed the nsI* in the linked xul files - fixed.
Comment 3•7 years ago
|
||
Equivalent version for c-c, carrying forward r+
Rebased so that patch from bug 1209626 can be applied on top.
Carrying forward r/a
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/1e66494caeb1
Switch permissionsManager and cookieViewer to use Services.jsm. r=frg
Comment 7•7 years ago
|
||
Description
•