Closed Bug 1570886 Opened 5 years ago Closed 5 years ago

Remove enableBigInt run-time flag

Categories

(Core :: JavaScript Engine, task, P1)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: wingo, Assigned: wingo)

References

Details

Attachments

(1 file)

Bug 1570886 - Remove enableBigInt run-time flag
47 bytes, text/x-phabricator-request
Details | Review

Now that BigInt is shipping in stable, the feature flag added in bug 1506542 is no longer necessary. This commit will remove the flag and all places that conditionally disable features if BigInt is unavailable.

Blocks: 1570895

Fuzzers: this patch removes the --no-bigint shell flag. Shout if that's really a problem for you (I'm not sure it still is with the new fuzz-flags.txt).

Flags: needinfo?(nth10sd)
Flags: needinfo?(choller)
Assignee: nobody → wingo

(In reply to Jan de Mooij [:jandem] from comment #2)

Fuzzers: this patch removes the --no-bigint shell flag. Shout if that's really a problem for you (I'm not sure it still is with the new fuzz-flags.txt).

Thanks for the headsup!

Flags: needinfo?(nth10sd)

This is fine for me, thanks for the headsup!

Flags: needinfo?(choller)
Priority: -- → P1
Keywords: checkin-needed

Pushed by opoprus@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/596ae187c20b
Remove enableBigInt run-time flag r=jandem

Keywords: checkin-needed

Backed out changeset 596ae187c20b (bug 1570886) for xpcshell failures at devtools/server/tests/unit/test_objectgrips-08.js

Backout: https://hg.mozilla.org/integration/autoland/rev/902723e23f94360267a907446f07a3e7b7981d5f

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=260075919&revision=596ae187c20b0bbcfd08de0e41e06cd0d684387a

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=260075919&repo=autoland&lineNumber=2482

[task 2019-08-06T09:46:07.593Z] 09:46:07 INFO - TEST-START | devtools/server/tests/unit/test_objectgrips-08.js
[task 2019-08-06T09:46:08.192Z] 09:46:08 WARNING - TEST-UNEXPECTED-FAIL | devtools/server/tests/unit/test_objectgrips-08.js | xpcshell return code: 0
[task 2019-08-06T09:46:08.193Z] 09:46:08 INFO - TEST-INFO took 594ms
[task 2019-08-06T09:46:08.193Z] 09:46:08 INFO - >>>>>>>
[task 2019-08-06T09:46:08.193Z] 09:46:08 INFO - PID 12899 | [12899, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/workspace/build/src/toolkit/crashreporter/nsExceptionHandler.cpp, line 2633
[task 2019-08-06T09:46:08.194Z] 09:46:08 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2019-08-06T09:46:08.194Z] 09:46:08 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2019-08-06T09:46:08.195Z] 09:46:08 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2019-08-06T09:46:08.196Z] 09:46:08 INFO - running event loop
[task 2019-08-06T09:46:08.197Z] 09:46:08 INFO - devtools/server/tests/unit/test_objectgrips-08.js | Starting
[task 2019-08-06T09:46:08.197Z] 09:46:08 INFO - (xpcshell/head.js) | test pending (2)
[task 2019-08-06T09:46:08.198Z] 09:46:08 INFO - PID 12899 | >>> Run thread front test against a regular DebuggerServer
[task 2019-08-06T09:46:08.199Z] 09:46:08 INFO - (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2019-08-06T09:46:08.199Z] 09:46:08 INFO - PID 12899 | JavaScript strict warning: resource://devtools/shared/client/debugger-client.js, line 603: ReferenceError: reference to undefined property "type"
[task 2019-08-06T09:46:08.200Z] 09:46:08 INFO - PID 12899 | DBG-TEST: resource://devtools/shared/client/debugger-client.js:603: strict error: ReferenceError: reference to undefined property "type"
[task 2019-08-06T09:46:08.203Z] 09:46:08 INFO - PID 12899 | DBG-TEST: head_dbg.js observed a console message: ReferenceError: reference to undefined property "type"
[task 2019-08-06T09:46:08.203Z] 09:46:08 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "type"" {file: "resource://devtools/shared/client/debugger-client.js" line: 603}]"
[task 2019-08-06T09:46:08.204Z] 09:46:08 INFO - PID 12899 | JavaScript strict warning: resource://devtools/shared/protocol/lazy-pool.js, line 102: ReferenceError: reference to undefined property "actorID"
[task 2019-08-06T09:46:08.205Z] 09:46:08 INFO - PID 12899 | DBG-TEST: resource://devtools/shared/protocol/lazy-pool.js:102: strict error: ReferenceError: reference to undefined property "actorID"
[task 2019-08-06T09:46:08.205Z] 09:46:08 INFO - PID 12899 | DBG-TEST: head_dbg.js observed a console message: ReferenceError: reference to undefined property "actorID"
[task 2019-08-06T09:46:08.206Z] 09:46:08 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "actorID"" {file: "resource://devtools/shared/protocol/lazy-pool.js" line: 102}]"

Flags: needinfo?(wingo)
Flags: needinfo?(wingo)
Keywords: checkin-needed

Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/145b187e750f
Remove enableBigInt run-time flag r=jandem

Keywords: checkin-needed

Backed out for perma xpcshell fails on test_objectgrips-08.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=retry%2Csuperseded%2Ctestfailed%2Cbusted%2Cexception&revision=145b187e750f9d296c4cbbc3ddf078964ea9a54f&selectedJob=260144738

Failre log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=260144738&repo=autoland&lineNumber=2650

[task 2019-08-06T16:55:35.993Z] 16:55:35 INFO - TEST-START | devtools/server/tests/unit/test_objectgrips-08.js
[task 2019-08-06T16:55:36.561Z] 16:55:36 WARNING - TEST-UNEXPECTED-FAIL | devtools/server/tests/unit/test_objectgrips-08.js | xpcshell return code: 0
[task 2019-08-06T16:55:36.561Z] 16:55:36 INFO - TEST-INFO took 566ms
[task 2019-08-06T16:55:36.561Z] 16:55:36 INFO - >>>>>>>
[task 2019-08-06T16:55:36.562Z] 16:55:36 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2019-08-06T16:55:36.562Z] 16:55:36 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2019-08-06T16:55:36.563Z] 16:55:36 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2019-08-06T16:55:36.563Z] 16:55:36 INFO - running event loop
[task 2019-08-06T16:55:36.563Z] 16:55:36 INFO - devtools/server/tests/unit/test_objectgrips-08.js | Starting
[task 2019-08-06T16:55:36.564Z] 16:55:36 INFO - (xpcshell/head.js) | test pending (2)
[task 2019-08-06T16:55:36.564Z] 16:55:36 INFO - PID 13218 | >>> Run thread front test against a regular DebuggerServer
[task 2019-08-06T16:55:36.564Z] 16:55:36 INFO - (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2019-08-06T16:55:36.564Z] 16:55:36 INFO - PID 13218 | JavaScript strict warning: resource://devtools/shared/client/debugger-client.js, line 603: ReferenceError: reference to undefined property "type"
[task 2019-08-06T16:55:36.564Z] 16:55:36 INFO - PID 13218 | DBG-TEST: resource://devtools/shared/client/debugger-client.js:603: strict error: ReferenceError: reference to undefined property "type"
[task 2019-08-06T16:55:36.564Z] 16:55:36 INFO - PID 13218 | DBG-TEST: head_dbg.js observed a console message: ReferenceError: reference to undefined property "type"
[task 2019-08-06T16:55:36.564Z] 16:55:36 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "type"" {file: "resource://devtools/shared/client/debugger-client.js" line: 603}]"
[task 2019-08-06T16:55:36.564Z] 16:55:36 INFO - PID 13218 | JavaScript strict warning: resource://devtools/shared/protocol/lazy-pool.js, line 102: ReferenceError: reference to undefined property "actorID"
[task 2019-08-06T16:55:36.564Z] 16:55:36 INFO - PID 13218 | DBG-TEST: resource://devtools/shared/protocol/lazy-pool.js:102: strict error: ReferenceError: reference to undefined property "actorID"
[task 2019-08-06T16:55:36.564Z] 16:55:36 INFO - PID 13218 | DBG-TEST: head_dbg.js observed a console message: ReferenceError: reference to undefined property "actorID"
[task 2019-08-06T16:55:36.564Z] 16:55:36 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "actorID"" {file: "resource://devtools/shared/protocol/lazy-pool.js" line: 102}]"
[task 2019-08-06T16:55:36.564Z] 16:55:36 INFO - TEST-PASS | devtools/server/tests/unit/test_objectgrips-08.js | - Thread client is paused - "paused" == "paused"
[task 2019-08-06T16:55:36.564Z] 16:55:36 INFO - TEST-PASS | devtools/server/tests/unit/test_objectgrips-08.js | - true == true
[task 2019-08-06T16:55:36.564Z] 16:55:36 INFO - TEST-PASS | devtools/server/tests/unit/test_objectgrips-08.js | - "attached" == "attached"
[task 2019-08-06T16:55:36.564Z] 16:55:36 INFO - Unexpected exception SyntaxError: missing ) after argument list at /builds/worker/workspace/build/tests/xpcshell/tests/devtools/server/tests/unit/test_objectgrips-08.js:10
[task 2019-08-06T16:55:36.564Z] 16:55:36 INFO - @/builds/worker/workspace/build/tests/xpcshell/tests/devtools/server/tests/unit/test_objectgrips-08.js:39:16
[task 2019-08-06T16:55:36.564Z] 16:55:36 INFO - @/builds/worker/workspace/build/tests/xpcshell/tests/devtools/server/tests/unit/test_objectgrips-08.js:13:12
[task 2019-08-06T16:55:36.565Z] 16:55:36 INFO - runThreadFrontTestWithServer@/builds/worker/workspace/build/tests/xpcshell/tests/devtools/server/tests/unit/head_dbg.js:965:11
[task 2019-08-06T16:55:36.566Z] 16:55:36 INFO - async*threadFrontTest/<@/builds/worker/workspace/build/tests/xpcshell/tests/devtools/server/tests/unit/head_dbg.js:978:11
[task 2019-08-06T16:55:36.566Z] 16:55:36 INFO - run_next_test/_run_next_test/<@/builds/worker/workspace/build/tests/xpcshell/head.js:1564:35
[task 2019-08-06T16:55:36.566Z] 16:55:36 INFO - _run_next_test@/builds/worker/workspace/build/tests/xpcshell/head.js:1564:38
[task 2019-08-06T16:55:36.566Z] 16:55:36 INFO - run@/builds/worker/workspace/build/tests/xpcshell/head.js:732:17
[task 2019-08-06T16:55:36.566Z] 16:55:36 INFO - _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:245:6
[task 2019-08-06T16:55:36.566Z] 16:55:36 INFO - _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:572:13
[task 2019-08-06T16:55:36.566Z] 16:55:36 INFO - @-e:1:14
[task 2019-08-06T16:55:36.566Z] 16:55:36 INFO - exiting test
[task 2019-08-06T16:55:36.566Z] 16:55:36 INFO - PID 13218 | JavaScript error: resource://testing-common/PromiseTestUtils.jsm, line 112: uncaught exception: Object
[task 2019-08-06T16:55:36.566Z] 16:55:36 INFO - <<<<<<<
[task 2019-08-06T16:55:36.569Z] 16:55:36 INFO - INFO | Result summary:
[task 2019-08-06T16:55:36.570Z] 16:55:36 INFO - INFO | Passed: 633
[task 2019-08-06T16:55:36.570Z] 16:55:36 WARNING - INFO | Failed: 1
[task 2019-08-06T16:55:36.570Z] 16:55:36 WARNING - One or more unittests failed.
[task 2019-08-06T16:55:36.570Z] 16:55:36 INFO - INFO | Todo: 0
[task 2019-08-06T16:55:36.571Z] 16:55:36 INFO - INFO | Retried: 2
[task 2019-08-06T16:55:36.571Z] 16:55:36 INFO - SUITE-END | took 626s
[task 2019-08-06T16:55:36.598Z] 16:55:36 INFO - Node moz-http2 server shutting down ...
[task 2019-08-06T16:55:36.600Z] 16:55:36 INFO - Process stderr
[task 2019-08-06T16:55:36.600Z] 16:55:36 INFO - (node:987) ExperimentalWarning: The http2 module is an experimental API.
[task 2019-08-06T16:55:36.675Z] 16:55:36 ERROR - Return code: 1
[task 2019-08-06T16:55:36.675Z] 16:55:36 INFO - TinderboxPrint: xpcshell-xpcshell<br/>633/<em class="testfail">1</em>/0
[task 2019-08-06T16:55:36.676Z] 16:55:36 WARNING - # TBPL FAILURE #
[task 2019-08-06T16:55:36.676Z] 16:55:36 WARNING - setting return code to 2
[task 2019-08-06T16:55:36.676Z] 16:55:36 WARNING - The xpcshell suite: xpcshell ran with return status: FAILURE
[task 2019-08-06T16:55:36.676Z] 16:55:36 INFO - Running post-action listener: _package_coverage_data
[task 2019-08-06T16:55:36.676Z] 16:55:36 INFO - Running post-action listener: _resource_record_post_action
[task 2019-08-06T16:55:36.677Z] 16:55:36 INFO - Running post-action listener: process_java_coverage_data
[task 2019-08-06T16:55:36.677Z] 16:55:36 INFO - [mozharness: 2019-08-06 16:55:36.677076Z] Finished run-tests step (success)
[task 2019-08-06T16:55:36.677Z] 16:55:36 INFO - Running post-run listener: _resource_record_post_run
[task 2019-08-06T16:55:36.733Z] 16:55:36 INFO - Validating Perfherder data against /builds/worker/workspace/mozharness/external_tools/performance-artifact-schema.json
[task 2019-08-06T16:55:36.737Z] 16:55:36 INFO - PERFHERDER_DATA: {"framework": {"name": "job_resource_usage"}, "suites": [{"subtests": [{"name": "cpu_percent", "value": 96.72300150829562}, {"name": "io_write_bytes", "value": 3859611648}, {"name": "io.read_bytes", "value": 45162496}, {"name": "io_write_time", "value": 458772}, {"name": "io_read_time", "value": 1008}], "extraOptions": ["e10s", "taskcluster-m5.large"], "name": "xpcshell.xpcshell.1.overall"}, {"subtests": [{"name": "time", "value": 36.762043952941895}, {"name": "cpu_percent", "value": 50.56805555555555}], "name": "xpcshell.xpcshell.1.install"}, {"subtests": [{"name": "time", "value": 0.01653289794921875}], "name": "xpcshell.xpcshell.1.stage-files"}, {"subtests": [{"name": "time", "value": 627.7413170337677}, {"name": "cpu_percent", "value": 99.45031948881788}], "name": "xpcshell.xpcshell.1.run-tests"}]}
[task 2019-08-06T16:55:36.738Z] 16:55:36 INFO - Total resource usage - Wall time: 664s; CPU: 99.0%; Read bytes: 45162496; Write bytes: 3859611648; Read time: 1008; Write time: 458772
[task 2019-08-06T16:55:36.739Z] 16:55:36 INFO - TinderboxPrint: CPU usage<br/>99.5%
[task 2019-08-06T16:55:36.740Z] 16:55:36 INFO - TinderboxPrint: I/O read bytes / time<br/>45,162,496 / 1,008
[task 2019-08-06T16:55:36.741Z] 16:55:36 INFO - TinderboxPrint: I/O write bytes / time<br/>3,859,611,648 / 458,772
[task 2019-08-06T16:55:36.742Z] 16:55:36 INFO - TinderboxPrint: CPU idle<br/>36.1 (2.7%)
[task 2019-08-06T16:55:36.743Z] 16:55:36 INFO - TinderboxPrint: CPU system<br/>183.3 (13.8%)
[task 2019-08-06T16:55:36.744Z] 16:55:36 INFO - TinderboxPrint: CPU user<br/>1,100.6 (82.9%)
[task 2019-08-06T16:55:36.744Z] 16:55:36 INFO - TinderboxPrint: Swap in / out<br/>0 / 0
[task 2019-08-06T16:55:36.746Z] 16:55:36 INFO - install - Wall time: 37s; CPU: 51.0%; Read bytes: 98304; Write bytes: 2122080256; Read time: 368; Write time: 307476
[task 2019-08-06T16:55:36.747Z] 16:55:36 INFO - stage-files - Wall time: 0s; CPU: Can't collect data; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
[task 2019-08-06T16:55:36.748Z] 16:55:36 INFO - run-tests - Wall time: 628s; CPU: 99.0%; Read bytes: 44728320; Write bytes: 1737531392; Read time: 504; Write time: 151296
[task 2019-08-06T16:55:36.839Z] 16:55:36 WARNING - returning nonzero exit status 2
[task 2019-08-06T16:55:36.864Z] cleanup

Backout: https://hg.mozilla.org/integration/autoland/rev/efd472b0cd90601f89d24cfc6fac3b2c9523d2d9

Flags: needinfo?(wingo)

this is just to say

i have removed
the curvy boi
that was present
in the evalled string

and which
js were probably saving
for closing an open argument list

Forgive me
it was extraneous
so curvy
and so bogus

(seriously, sorry for the clownshoes on this one. i have run this test locally now and it passes)

Flags: needinfo?(wingo)
Keywords: checkin-needed

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d499df464e4c
Remove enableBigInt run-time flag r=jandem

Keywords: checkin-needed

https://hg.mozilla.org/mozilla-central/rev/d499df464e4c

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: