Closed Bug 1570901 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 18249 - Update layout tree rebuild root after removing pseudo element.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18249 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18249
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

Update layout tree rebuild root after removing pseudo element.

We tried to avoid marking the pseudo element when it was about to be
removed, but the pseudo element earlied out before removal if it wasn't
marked for re-attachment causing the element not to be removed.

Notify the StyleEngine about removal instead, so that it can update the
traversal root. For normal elements the StyleEngine is notified through
ChildrenRemoved().

Bug: 989894
Change-Id: Ia2bf52c9bed157c4ac806a10b9367b0f99038974
Reviewed-on: https://chromium-review.googlesource.com/1732096
WPT-Export-Revision: fa4efb6d726fd6938c17ca5809e844abafce3630

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2aac156b9c11 [wpt PR 18249] - Update layout tree rebuild root after removing pseudo element., a=testonly

https://hg.mozilla.org/mozilla-central/rev/2aac156b9c11

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.