Closed Bug 1570959 Opened 1 year ago Closed 4 months ago

Port bug 1551334 to Thunderbird - Update hiddenWindow.xul on OSX to xhtml

Categories

(Thunderbird :: General, task, P1)

Unspecified
macOS

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 78.0

People

(Reporter: mkmelin, Assigned: khushil324)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Once bug 1570955 is done, migrate the hidden window.

The renames are already done. But let's still to the rename to hiddenWindowMac.xhtml and what more is needed to stay more in sync.

Assignee: nobody → khushil324

Let's make sure to do this so we don't have surprises, like (maybe) bug 1635734.

Priority: -- → P1

Here, they are using shared .inc files to import all the things between hiddenWindow and browser.html:
https://searchfox.org/mozilla-central/search?q=%23include+global-scripts.inc&path=
https://searchfox.org/mozilla-central/search?q=include+browser-sets.inc&path=
https://searchfox.org/mozilla-central/search?q=%23include+browser-menubar.inc&path=
https://searchfox.org/mozilla-central/search?q=%23include+browser-doctype.inc&path=

So should we do the same for messenger.xhtml and hiddenWindow.html(which will be renamed to hiddenWindowMac.xhtml)?

Toolbox, keyset and commandset are in such form. We just need to do it for DTD files, Scripts, and Stringbundle.

Attachment #9147434 - Flags: review?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Comment on attachment 9147434 [details] [diff] [review]
Bug-1570959_Update-hiddenWindow-to-hiddenWindowMac-0.patch

Review of attachment 9147434 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin with the naming change below

::: mail/base/content/hiddenWindowMac.xhtml
@@ +7,2 @@
>  <!DOCTYPE window [
> +#include messenger-doctype.inc

please make it named .inc.dtd

It's a pain trying to figure out tree wide changes if the extensions aren't as expected.
Attachment #9147434 - Flags: review?(mkmelin+mozilla) → review+

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/8d4c676d5d53
Update hiddenWindow.xhtml on OSX to hiddenWindowMac.xhtml. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 78.0
You need to log in before you can comment on or make changes to this bug.