1570959 - Port bug 1551334 to Thunderbird - Update hiddenWindow.xul on OSX to xhtml

Status: RESOLVED FIXED

(Thunderbird :: General, task, P1)

Description

[Magnus Melin [:mkmelin]]

Once bug 1570955 is done, migrate the hidden window.

Comment 1

[Magnus Melin [:mkmelin]]

The renames are already done. But let's still to the rename to hiddenWindowMac.xhtml and what more is needed to stay more in sync.

Comment 2

[Magnus Melin [:mkmelin]]

Let's do this bug for all the syncing - https://searchfox.org/mozilla-central/source/browser/base/content/macWindow.inc.xhtml

Comment 3

[Magnus Melin [:mkmelin]]

Let's make sure to do this so we don't have surprises, like (maybe) bug 1635734.

Comment 4

[Khushil Mistry [:khushil324]]

Here, they are using shared .inc files to import all the things between hiddenWindow and browser.html:
https://searchfox.org/mozilla-central/search?q=%23include+global-scripts.inc&path=
https://searchfox.org/mozilla-central/search?q=include+browser-sets.inc&path=
https://searchfox.org/mozilla-central/search?q=%23include+browser-menubar.inc&path=
https://searchfox.org/mozilla-central/search?q=%23include+browser-doctype.inc&path=

So should we do the same for messenger.xhtml and hiddenWindow.html(which will be renamed to hiddenWindowMac.xhtml)?

Comment 5

[Khushil Mistry [:khushil324]]

Toolbox, keyset and commandset are in such form. We just need to do it for DTD files, Scripts, and Stringbundle.

Comment 6

[Khushil Mistry [:khushil324]]

Attachment: Bug-1570959_Update-hiddenWindow-to-hiddenWindowMac-0.patch

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9147434 [details] [diff] [review]
Bug-1570959_Update-hiddenWindow-to-hiddenWindowMac-0.patch

Review of attachment 9147434 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin with the naming change below

::: mail/base/content/hiddenWindowMac.xhtml
@@ +7,2 @@
>  <!DOCTYPE window [
> +#include messenger-doctype.inc

please make it named .inc.dtd

It's a pain trying to figure out tree wide changes if the extensions aren't as expected.

Comment 8

[Khushil Mistry [:khushil324]]

Attachment: Bug-1570959_Update-hiddenWindow-to-hiddenWindowMac-1.patch

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8d4c676d5d53
Update hiddenWindow.xhtml on OSX to hiddenWindowMac.xhtml. r=mkmelin