1570972 - "Last modified" section does not update after a login username has been edited

Status: NEW

(Firefox :: about:logins, defect, P5)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: last_modified_section.mp4

[Affected versions]:

• Firefox latest Nightly 70.0a1 (2019-08-01) (64-bit)

[Affected Platforms]:

• Mac 10.14
• Windows 10 x64
• Ubuntu 18.04 x64

[Prerequisites]:

• Have at least one login saved in the past days.

[Steps to reproduce]:

1. Open the browser and navigate to the "about:logins" page.
2. Click on any login saved in the past days from the Login list.
3. Click on the “Edit” button and change the username.
4. Click on the "Save Changes" button and observe the "Last modified: <date>" section.

[Expected result]:

• The "Last modified: <date>" section is correctly updated.

[Actual result]:

• The "Last modified: <date>" section is not updated.

[Notes]:

• Attached a screen recording with the issue.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

That line only corresponds to when the password was last changed. In practice we shouldn't see many people changing usernames or website addresses often. I confirmed that changing the password correctly updates the Last Modified date.

Comment 2

[Matthew N. [:MattN]]

It's also not clear if we should be updating this date for username changes. Maybe we can make the string more clear though.

Comment 4

[David Durst [:ddurst]]

Confirmed in #c1; setting NI for Product (so we don't lose it) regarding the question in #c2.

Comment 5

[Matthew N. [:MattN]]

Mass removing [skyline] and [passwords:management] from about:logins bugs which are no longer useful.

Comment 6

[lrionth]

I think changing a username should change the last modified date.

If someone were to switch to a new email address, they would need to change a lot of the username/email addresses in about:logins. Switching the sort to last modified would show which accounts you have updated to your new email address.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit auto_nag documentation.