Closed
Bug 1571031
Opened 5 years ago
Closed 5 years ago
Change Location::Reload to take an ErrorResult.
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
Not sure what you think of the return aRv.Throw() pattern, I find it nice, but
it seems we don't use it a lot.
Also Location.h is inconsistent on aError vs. aRv, if you want me to change to
one or the other let me know.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aef1c437643e Change Location::Reload to take an ErroResult, since it's what both callers expect. r=bzbarsky
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/37229cef2cc7 followup: Don't throw NS_OK. r=bustage
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/aef1c437643e
https://hg.mozilla.org/mozilla-central/rev/37229cef2cc7
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•