1571051 - Fix some small problems for the platform encoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Alastor Wu [:alwu]]

There are some small problems for the platform encoder, we have to fix them before starting using the platform encoder.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1571051 - part1 : use thread safe refcounting for PlatformEncoderModule.

We don't have a contraint for using PlatformEncoderModule in the specific thread only, so we should use thread-safe refcounting for it, like PlatformDecoderModule.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1571051 - part2 : keep CodecSpecific const when doing the std::forward.

As we are not going to modify the CodecSpecific, it should keep const when we forward it.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1571051 - part3 : mark MediaRawData as a keyframe.

If the encoded frame is a keyframe, we should also mark the MediaRawData which would contain the data from this encoded frame as a keyframe.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1571051 - part4 : use Cb buffer in the second plane.

The second plane should store data of the Cb buffer's value, not the Cr's.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f173d38fe963
part1 : use thread safe refcounting for PlatformEncoderModule. r=jolin
https://hg.mozilla.org/integration/autoland/rev/be1941df5f7c
part2 : keep CodecSpecific const when doing the std::forward. r=jolin
https://hg.mozilla.org/integration/autoland/rev/2b7023390939
part3 : mark MediaRawData as a keyframe. r=jolin
https://hg.mozilla.org/integration/autoland/rev/ae95c555ecb7
part4 : use Cb buffer in the second plane. r=jolin

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f173d38fe963
https://hg.mozilla.org/mozilla-central/rev/be1941df5f7c
https://hg.mozilla.org/mozilla-central/rev/2b7023390939
https://hg.mozilla.org/mozilla-central/rev/ae95c555ecb7