Remove the "leaf" profiler feature
Categories
(Core :: Gecko Profiler, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: gregtatum, Assigned: mozbugz)
References
Details
Attachments
(1 file)
We currently support stack walking everywhere, and when it fails, we (should?) fall back to leaf stacks. The only place we don't currently collect full stacks is on macOS release builds see Bug 1451902. The leaf option is a bit confusing in how it works, and doesn't provide much value.
|
Reporter | |
Updated•5 years ago
|
|
Assignee | |
Comment 2•2 years ago
|
||
(Florian Quèze [:florian] from bug 1766895 comment #0)
Now that we have correct stacks even on Mac release builds, the Native Leaf Stack feature is left without purpose, we should remove it.
|
|
Assignee | |
Comment 3•2 years ago
|
||
We currently support stack walking everywhere, and when it fails, we fall back
to leaf stacks. The leaf option is a bit confusing in how it works, and doesn't
provide much value.
|
||
Updated•2 years ago
|
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/523ef50a4e16 Remove the "leaf" profiler feature - r=canaltinova
|
||
Comment 5•2 years ago
|
||
Backed out for causing xpcshell failures at test_ext_geckoProfiler_schema.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/137d960212a281e9c00e3df16c50873a16183a4c
Failure log: https://treeherder.mozilla.org/logviewer?job_id=386643359&repo=autoland&lineNumber=3015
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f85e05a4cedf Remove the "leaf" profiler feature - r=canaltinova
|
||
Comment 8•2 years ago
|
||
| bugherder | ||
Description
•