Closed Bug 1571120 Opened 4 months ago Closed 3 months ago

Using paths for the old Extension install policy doesn't work anymore on Windows

Categories

(Firefox :: Enterprise Policies, defect, P3)

x86_64
Windows
defect

Tracking

()

VERIFIED FIXED
Firefox 70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- verified
firefox68 --- wontfix
firefox69 --- verified
firefox70 --- verified

People

(Reporter: mkaply, Assigned: mkaply)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

When we switched to the new extension install code, we moved towards using a failing URI creation to detect file paths.

This doesn't work on Windows because C:/foo/bar is a "valid" URI.

Keywords: regression
Regressed by: 1522823
Duplicate of this bug: 1574951
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/e7434e7979b2
Check for file paths before assuming a URL. r=aswan
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

Comment on attachment 9084099 [details]
Bug 1571120 - Check for file paths before assuming a URL.

Beta/Release Uplift Approval Request

  • User impact if declined: Using the original syntax for installing extensions via policy doesn't work. (regression)
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Create an extension install policy on Windows using a Windows path. Verify it now installs.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is a policy only change with a test.
  • String changes made/needed:

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy only, regression.
  • User impact if declined: Using the original syntax for installing extensions via policy doesn't work. (regression)
  • Fix Landed on Version: 70
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Policy only.
  • String or UUID changes made by this patch:
Attachment #9084099 - Flags: approval-mozilla-esr68?
Attachment #9084099 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9084099 [details]
Bug 1571120 - Check for file paths before assuming a URL.

policy fix for 68.1esr and 69.0b16

Attachment #9084099 - Flags: approval-mozilla-esr68?
Attachment #9084099 - Flags: approval-mozilla-esr68+
Attachment #9084099 - Flags: approval-mozilla-beta?
Attachment #9084099 - Flags: approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I have managed to reproduce this issue using Firefox 70.0a1 (BuildId:20190812095530) on Windows 10 64bit.

This issue is verified fixed using Firefox 70.0a1 (BuildId:20190826094255), Firefox 69.0b16 (BuildId:20190822210915) and Firefox 68.1.0esr (provided in comment 7) on Windows 10 64bit.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.