1571120 - Using paths for the old Extension install policy doesn't work anymore on Windows

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P3)

Description

[Mike Kaply [:mkaply]]

When we switched to the new extension install code, we moved towards using a failing URI creation to detect file paths.

This doesn't work on Windows because C:/foo/bar is a "valid" URI.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1571120 - Check for file paths before assuming a URL.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7434e7979b2
Check for file paths before assuming a URL. r=aswan

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e7434e7979b2

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 9084099 [details]
Bug 1571120 - Check for file paths before assuming a URL.

Beta/Release Uplift Approval Request

• User impact if declined: Using the original syntax for installing extensions via policy doesn't work. (regression)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Create an extension install policy on Windows using a Windows path. Verify it now installs.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a policy only change with a test.
• String changes made/needed:

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy only, regression.
• User impact if declined: Using the original syntax for installing extensions via policy doesn't work. (regression)
• Fix Landed on Version: 70
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy only.
• String or UUID changes made by this patch:

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9084099 [details]
Bug 1571120 - Check for file paths before assuming a URL.

policy fix for 68.1esr and 69.0b16

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/26153798092d

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f52321e0fba0

Comment 9

[Emil Ghitta, QA [:emilghitta]]

I have managed to reproduce this issue using Firefox 70.0a1 (BuildId:20190812095530) on Windows 10 64bit.

This issue is verified fixed using Firefox 70.0a1 (BuildId:20190826094255), Firefox 69.0b16 (BuildId:20190822210915) and Firefox 68.1.0esr (provided in comment 7) on Windows 10 64bit.