1571143 - Task category menulist broken on trunk

Status: VERIFIED FIXED

(Calendar :: Dialogs, defect)

Description

[Alessandro Castellani [:aleca]]

Attachment: tb-trunk.png

The Category menulist for tasks is broken on trunk, but works and looks OK on 68.

Issues:

• The input field is not styled and doesn't have the left icon.
• The dropdown list is too long and doesn't show a scrollbar.
• The menu items don't show the checkbox when unchecked.
• At every item selection, the dropdown closes and reopens.

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: tb-68.png

A comparison with 68

Comment 2

[Geoff Lankow (:darktrojan)]

I'm not sure exactly what it's meant to look like on Mac, but unless things have been changed since I last remade this, the input field is not meant to have any special style or icon, and menu items aren't meant to have a checkbox (just the mark itself if required). As for length and scrolling, I have no idea. The "closing on selection" thing could definitely be improved though, and I've since learnt a better way to do that.

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2022-06-22 14.52.04.png

Old bug but still relevant with the recent style changes.

The checkmark appears on top of the category color.
Richard, would you be able to tackle this?

Comment 4

[Richard Marti (:Paenglab)]

I can try but this looks not so easy as the menu-iconic-icon is used for both the category colour and the checkmark.

Or how about using the menuitem label have the category colour like we do for the tags?

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Bug 1571143 - Separate the checkmark and the category in the event category menupopup. r=aleca

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6855cb1a71a6
Separate the checkmark and the category in the event category menupopup. r=aleca

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 9282944 [details]
Bug 1571143 - Separate the checkmark and the category in the event category menupopup. r=aleca

[Approval Request Comment]
User impact if declined: no good visibility in menupopup when the category is checked
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9282944 [details]
Bug 1571143 - Separate the checkmark and the category in the event category menupopup. r=aleca

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 103.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/390d04deca41

Comment 10

[Wayne Mery (:wsmwk)]

optimistically approving for TB102.0.1 - assuming it will pass beta over the next several days

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 102.0.1:
https://hg.mozilla.org/releases/comm-esr102/rev/1d8313bc37b9

Comment 12

[WaltS48 [:walts48]]

Still seeing no checkbox in Daily Build ID 20220705101731, 103.0b2 and a quick check of 102.0.1 on Fedora 35 Workstation, and the dropdown just closes on every selection.

Comment 13

[Richard Marti (:Paenglab)]

Attachment: Fedora.png

I see this on Fedora. You not?

Comment 14

[WaltS48 [:walts48]]

Yes, that is what I see, but I thought there were supposed to be checkboxes.

Comment 15

[Richard Marti (:Paenglab)]

No checkboxes would make the menu too busy and would deviate from the colour bubbles.

Comment 16

[WaltS48 [:walts48]]

Okay, then I'm verifying.

Comment 17

[Meichthys]

Sorry to respond to a closed bug, but I'm still seeing the dropdown close after every selection on v103.0b3. Was this addressed in the fix?

Comment 18

[Richard Marti (:Paenglab)]

No.

Comment 19

[Meichthys]

Ok, Richard. Thanks. I'll look to see if that bug/enhancement request already exists, if not I'll file one.
It looks like the fixed check icon does appear correctly now for me. https://bugzilla.mozilla.org/show_bug.cgi?id=1744094 could be another visually appealing option (or alternative) when multiple categories are selected.

Comment 20

[Rob Lemley [:rjl]]

Comment on attachment 9282944 [details]
Bug 1571143 - Separate the checkmark and the category in the event category menupopup. r=aleca

[Triage Comment]