Closed Bug 1571143 Opened 3 years ago Closed 3 months ago

Task category menulist broken on trunk

Categories

(Calendar :: Dialogs, defect)

defect
Not set
normal

Tracking

(thunderbird_esr102 verified, thunderbird102? affected, thunderbird103 verified, thunderbird104 affected)

VERIFIED FIXED
104 Branch
Tracking Status
thunderbird_esr102 --- verified
thunderbird102 ? affected
thunderbird103 --- verified
thunderbird104 --- affected

People

(Reporter: aleca, Assigned: Paenglab)

Details

(Whiteboard: [TM:102.0.1optimistic])

Attachments

(3 files, 2 obsolete files)

Attached image tb-trunk.png (obsolete) —

The Category menulist for tasks is broken on trunk, but works and looks OK on 68.

Issues:

  • The input field is not styled and doesn't have the left icon.
  • The dropdown list is too long and doesn't show a scrollbar.
  • The menu items don't show the checkbox when unchecked.
  • At every item selection, the dropdown closes and reopens.
Attached image tb-68.png (obsolete) —

A comparison with 68

Component: Theme → Tasks
Product: Thunderbird → Calendar
Flags: needinfo?(geoff)

I'm not sure exactly what it's meant to look like on Mac, but unless things have been changed since I last remade this, the input field is not meant to have any special style or icon, and menu items aren't meant to have a checkbox (just the mark itself if required). As for length and scrolling, I have no idea. The "closing on selection" thing could definitely be improved though, and I've since learnt a better way to do that.

Flags: needinfo?(geoff)
Version: unspecified → Trunk

Old bug but still relevant with the recent style changes.

The checkmark appears on top of the category color.
Richard, would you be able to tackle this?

Attachment #9082810 - Attachment is obsolete: true
Attachment #9082811 - Attachment is obsolete: true
Flags: needinfo?(richard.marti)
Component: Tasks → Dialogs

I can try but this looks not so easy as the menu-iconic-icon is used for both the category colour and the checkmark.

Or how about using the menuitem label have the category colour like we do for the tags?

Flags: needinfo?(richard.marti)
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Target Milestone: --- → 104 Branch

Pushed by nicolai@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/6855cb1a71a6
Separate the checkmark and the category in the event category menupopup. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED

Comment on attachment 9282944 [details]
Bug 1571143 - Separate the checkmark and the category in the event category menupopup. r=aleca

[Approval Request Comment]
User impact if declined: no good visibility in menupopup when the category is checked
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9282944 - Flags: approval-comm-esr102?
Attachment #9282944 - Flags: approval-comm-beta?

Comment on attachment 9282944 [details]
Bug 1571143 - Separate the checkmark and the category in the event category menupopup. r=aleca

[Triage Comment]
Approved for beta

Attachment #9282944 - Flags: approval-comm-beta? → approval-comm-beta+

optimistically approving for TB102.0.1 - assuming it will pass beta over the next several days

Whiteboard: [TM:102.0.1optimistic]

Still seeing no checkbox in Daily Build ID 20220705101731, 103.0b2 and a quick check of 102.0.1 on Fedora 35 Workstation, and the dropdown just closes on every selection.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached image Fedora.png

I see this on Fedora. You not?

Flags: needinfo?(wls220spring)

Yes, that is what I see, but I thought there were supposed to be checkboxes.

Flags: needinfo?(wls220spring)

No checkboxes would make the menu too busy and would deviate from the colour bubbles.

Status: REOPENED → RESOLVED
Closed: 3 months ago3 months ago
Resolution: --- → FIXED

Okay, then I'm verifying.

Sorry to respond to a closed bug, but I'm still seeing the dropdown close after every selection on v103.0b3. Was this addressed in the fix?

No.

Ok, Richard. Thanks. I'll look to see if that bug/enhancement request already exists, if not I'll file one.
It looks like the fixed check icon does appear correctly now for me. https://bugzilla.mozilla.org/show_bug.cgi?id=1744094 could be another visually appealing option (or alternative) when multiple categories are selected.

Comment on attachment 9282944 [details]
Bug 1571143 - Separate the checkmark and the category in the event category menupopup. r=aleca

[Triage Comment]

Attachment #9282944 - Flags: approval-comm-esr102? → approval-comm-esr102+
You need to log in before you can comment on or make changes to this bug.