Closed Bug 1571196 Opened 3 years ago Closed 3 years ago

The select iframe popup menu cannot be closed when the `Disable Popup Auto-hide` is turned on.

Categories

(DevTools :: Inspector, defect)

70 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1569410

People

(Reporter: nayinain, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Attached video capture.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

  1. Install ublock-origin https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/?src=searchs
  2. Open about:debugging#/runtime/this-firefox page.
  3. Inspect ublock-origin.
  4. Turned on Disable Popup Auto-hide in the meatball menu.
  5. Click ublock-origin extension toolbutton to open the popup menu.
  6. Click the select iframe button at the left of meatball menu button.
  7. Select '/popup.html'

Actual results:

The select iframe popup menu cannot be closed.

Expected results:

The select iframe popup menu will be closed.

Has STR: --- → yes
Keywords: regression

:nayinain, could you try to find a regression range in using for example mozregression?

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #1)

:nayinain, could you try to find a regression range in using for example mozregression?

Regression range:

2019-08-03T21:22:51: INFO : Narrowed inbound regression window from [a1c80c3d, 362df462] (4 builds) to [ad447cf8, 362df462] (2 builds) (~1 steps left)
2019-08-03T21:22:51: DEBUG : Starting merge handling...
2019-08-03T21:22:51: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=362df4629f8f1fd5ed0eece429b77499a77bb955&full=1
2019-08-03T21:22:53: DEBUG : Found commit message:
Bug 1306054 - Use custom tooltip for inactive properties r=jdescottes,flod,rcaliman

###Changes

Probably the most important change apart from the tooltips is that we now only support one property at a time. This allows us to short circuit at the first invalid property and improve performance. This was previously agreed with Razvan but there were some relics left in the code.

toolbox.xul

  • Added tooltips.ftl

....................
https://treeherder.mozilla.org/#/jobs?repo=try&revision=de28939206d444dc4b534a3e5cc7a84b8797bec3

Differential Revision: https://phabricator.services.mozilla.com/D29372

2019-08-03T21:22:53: DEBUG : Did not find a branch, checking all integration branches
2019-08-03T21:22:53: INFO : The bisection is done.
2019-08-03T21:22:53: INFO : Stopped

Has Regression Range: --- → yes
Regressed by: 1306054

Thanks for filing, this is strangely similar to bug 1569557 where a popup remains on the screen and Firefox cannot be closed.
The identified regressing bug 1306054 did touched tooltips, so that could be the reason.
Julian, does this ring a bell? I feel like some recent changes in tooltips might have caused that, but I'm not sure.

Flags: needinfo?(jdescottes)
See Also: → 1569557

This is most likely a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=1569410

The issue comes from https://phabricator.services.mozilla.com/D29372 which started applying ui.popup.disable_autohide to HTML tooltips.
It was a nice to have, in order to work on DevTools tooltips, but I think we should we just revert this particular change for now, until we have a better solution.

This "disable popup autohide" should not affect its own toolbox, which is sadly the case when using it from about:devtools-toolbox tabs. And we can't just hide the option because autohide is mandatory in order to debug extension popups.
Maybe we could have a different pref and menu item that is only displayed from the browser toolbox and that affects DevTools tooltips separately from other tooltips.

Flags: needinfo?(jdescottes)

Ok, thanks Julian, let's dupe it for now and re-open if it turns out to be different.

Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1569410
You need to log in before you can comment on or make changes to this bug.