15712 - double-click broken on linux

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Akkana Peck]

Someone changed double-click handling to
expect double-clicks to send NS_MOUSE_*_BUTTON_DOWN instead of
NS_MOUSE_*_DOUBLE_CLICK.  This was something that everybody agreed was a
good idea to do eventually, but nobody bothered to mention that the
change had actually happened in the XP code and so the platform event
handlers should follow suit.

I'm attaching a patch that fixes it.  I can't check it in without a review, so
I'm filing this to Pavlov to either review it, or check in a different fix.

Comment 1

[Akkana Peck]

M11 (though really should be in M10 since I think that's where it broke).

Comment 2

[Akkana Peck]

Attachment: Patch to fix gtk double-click events

Comment 3

[Akkana Peck]

Fixed.

Comment 4

[John Unruh]

Verified per akkana's comments.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c377de4b74a
No bug - Update Cargo.lock after merging a servo/servo#15712 on a CLOSED TREE

Comment 6

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/be511b0830b2
[fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/15712)